Visitar URL original
feat(api_core): add retry param into PollingFuture() and it's inheritors by IlyaFaer · Pull Request #9923 · googleapis/google-cloud-python · GitHub
Skip to content

feat(api_core): add retry param into PollingFuture() and it's inheritors - #9923

Merged
busunkim96 merged 4 commits into
googleapis:masterfrom
MaxxleLLC:bigquery_retry_param
Jan 24, 2020
Merged

feat(api_core): add retry param into PollingFuture() and it's inheritors#9923
busunkim96 merged 4 commits into
googleapis:masterfrom
MaxxleLLC:bigquery_retry_param

Conversation

@IlyaFaer

@IlyaFaer IlyaFaer commented Dec 6, 2019 •
edited
Loading

Copy link
Copy Markdown

Towards #6197

Looks like it's the last thing that should be done for this issue. CMIIW.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2019
IlyaFaer
IlyaFaer commented Dec 6, 2019
View reviewed changes
Comment thread api_core/google/api_core/future/polling.py Resolved
Comment thread api_core/tests/unit/test_operation.py Resolved
Comment thread api_core/google/api_core/operation.py
# RPC as it will not change once done.
if not self._operation.done:
self._operation = self._refresh()
self._operation = self._refresh(retry=retry)

@IlyaFaer IlyaFaer Dec 6, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding retry into inheritor of the PollingFuture() (the one above) and passing it further. As self._refresh is functools.partial, we can just pass retry as a named arg - it'll be added to those args which were prepared while creating functools.partial

@IlyaFaer

IlyaFaer commented Dec 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Some BigQuery tests failed, but, as I see, they are failing in pure master too. And got an error in Sphinx:

sphinx.errors.SphinxWarning: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://requests.kennethreitz.org/en/stable/objects.inv' not fetchable due to <class 'requests.exceptions.ConnectionError'>: HTTPSConnectionPool(host='requests.kennethreitz.org', port=443): Max retries exceeded with url: /en/stable/objects.inv (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7f0555132910>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))

@IlyaFaer
IlyaFaer marked this pull request as ready for review December 6, 2019 15:14
@IlyaFaer
IlyaFaer requested a review from a team December 6, 2019 15:14
IlyaFaer
Revert "Lint fix."
22e8c11 
This reverts commit 13b8553.
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2019
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 17, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 17, 2019
@tswast
tswast requested review from a team and removed request for a team January 23, 2020 16:43
tswast
tswast approved these changes Jan 23, 2020
View reviewed changes

@tswast tswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for your patience in the review.

I'd like an API core owner to sign off as well, such as @busunkim96

@busunkim96
busunkim96 merged commit 8e7b7f8 into googleapis:master Jan 24, 2020
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
@IlyaFaer
IlyaFaer deleted the bigquery_retry_param branch September 24, 2020 08:02
parthea pushed a commit that referenced this pull request Nov 24, 2025
Gurov Ilya @busunkim96
feat(api_core): add retry param into PollingFuture() and it's inherit…
f7e4c7c 
…ors (#9923)

* feat(api_core): add retry param into PollingFuture() and it's inheritors

Towards #6197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes
@tseaver tseaver Awaiting requested review from tseaver
@jba jba Awaiting requested review from jba
+1 more reviewer
@busunkim96 busunkim96 busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IlyaFaer @tswast @busunkim96 @googlebot @yoshi-kokoro