RowCells are not actually serializeable #384

Activity

1. product-auto-label

   added

   api: bigtableIssues related to the googleapis/java-bigtable API.Issues related to the googleapis/java-bigtable API.

   on Aug 11, 2020
2. yoshi-automation

   added

   triage meI really want to be triaged.I really want to be triaged.

   🚨This issue needs some love.This issue needs some love.

   on Aug 12, 2020
3. kolea2

   added

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   and removed

   triage meI really want to be triaged.I really want to be triaged.

   🚨This issue needs some love.This issue needs some love.

   on Aug 19, 2020
4. dmitry-fa

   self-assigned this

   on Aug 28, 2020
5. dmitry-fa commented on Aug 31, 2020

   

   dmitry-fa

   on Aug 31, 2020

   Contributor

   More actions

   @igorbernstein2, the bad news: RowCell is abstract and marked as @AutoValue, which means its implementation is generated.
   If I read the @AutoValue documentation correctly we can't customize serialization. I see several ways of fixing the issue, but none of them looks good to me:

   • RowCell instances are created by RowCell.create() method, implemented like:

   public static RowCell create(... List<String> labels, ...) {
      return new AutoValue_RowCell(...,labels);
   }
   

   method. We can do something like:

     try {
        tryToSerialize(labels)
     } catch (Exception e) {
        labels = ArrayList.of(labels)
     }
   

   or simple:

     labels = ArrayList.of(labels)
   

   • We can add post-compilation step to the build to instrument AutoValue_RowCell.class and insert private void writeObject() method. (a bit of hardcore)

   • Stop using @AutoValue and implement the custom serialization in the manually implemented subclass.

   Do you have any preferences or suggestions?
6. igorbernstein2 commented on Aug 31, 2020

   

   igorbernstein2

   on Aug 31, 2020

   ContributorAuthor

   More actions

   I think the easiest way would be to update create

   public static RowCell create(
         @Nonnull String family,
         @Nonnull ByteString qualifier,
         long timestamp,
         @Nonnull List<String> labels,
         @Nonnull ByteString value) {
       // Ensure that the list is serializable and optimize for the common case
       labels = labels.isEmpty() ? ImmutableList.of() : ImmutableList.copyOf(labels);
       return new AutoValue_RowCell(family, qualifier, timestamp, value,ImmutableList. labels);
     }
7. igorbernstein2

   closed this as completedin #407on Sep 8, 2020