Visitar URL original
fix(bigtable): plumb transport type correctly by sushanb · Pull Request #2824 · googleapis/java-bigtable · GitHub
Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

fix(bigtable): plumb transport type correctly - #2824

Merged
sushanb merged 13 commits into
mainfrom
fix_l
Mar 3, 2026
Merged

fix(bigtable): plumb transport type correctly#2824
sushanb merged 13 commits into
mainfrom
fix_l

Conversation

@sushanb

@sushanb sushanb commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sushanb
sushanb requested review from a team as code owners March 2, 2026 15:25
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 2, 2026
igorbernstein2
igorbernstein2 suggested changes Mar 2, 2026
View reviewed changes
Comment thread ...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/MetadataExtractorInterceptor.java Outdated

@Nullable
public static SidebandData from(CallOptions callOptions) {
return callOptions == null ? null : callOptions.getOption(KEY);

@igorbernstein2 igorbernstein2 Mar 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

callOptions should never be null

Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
new SimpleForwardingClientCallListener<RespT>(responseListener) {
@Override
public void onClose(Status status, Metadata trailers) {
entry.checkAndSetTransportType(callOptions);

@igorbernstein2 igorbernstein2 Mar 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should put this in onHeaders

@sushanb sushanb Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I was using Status earlier to set unknown type. It was redundant. fixed it.

Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
@sushanb
sushanb merged commit d25f39c into main Mar 3, 2026
28 checks passed
@sushanb
sushanb deleted the fix_l branch March 3, 2026 22:12
@release-please release-please Bot mentioned this pull request Mar 3, 2026
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 2.75.0 (#2832)
7745013 
🤖 I have created a release *beep* *boop*
---


## [2.75.0](https://togithub.com/googleapis/java-bigtable/compare/v2.74.0...v2.75.0) (2026-03-24)


### Features

* Expose generated GAPIC instance admin client ([#2828](https://togithub.com/googleapis/java-bigtable/issues/2828)) ([7c42799](https://togithub.com/googleapis/java-bigtable/commit/7c42799d45dbefb172c567ab6242f2a6f27a1eba))


### Bug Fixes

* **bigtable:** Add gauge handling ([#2830](https://togithub.com/googleapis/java-bigtable/issues/2830)) ([915733b](https://togithub.com/googleapis/java-bigtable/commit/915733bbaf21626c87bb868070087c382ba0932e))
* **bigtable:** Plumb transport type correctly ([#2824](https://togithub.com/googleapis/java-bigtable/issues/2824)) ([d25f39c](https://togithub.com/googleapis/java-bigtable/commit/d25f39c1f46263bd635731aa37ba71374c64c31c))
* Fix automated backup ([#2844](https://togithub.com/googleapis/java-bigtable/issues/2844)) ([5dc6829](https://togithub.com/googleapis/java-bigtable/commit/5dc68297dc1f002cb527a710443d5c208d712bc1))
* Fix race in emulator controller ([#2836](https://togithub.com/googleapis/java-bigtable/issues/2836)) ([17707be](https://togithub.com/googleapis/java-bigtable/commit/17707be3f4bfede9e4541d00350c400de937e3b6))
* Use all known headers to detect connectivity errors ([#2841](https://togithub.com/googleapis/java-bigtable/issues/2841)) ([6466166](https://togithub.com/googleapis/java-bigtable/commit/6466166b417c9a5052c512f38047a7fac19b5d75))


### Dependencies

* Update shared dependencies ([#2850](https://togithub.com/googleapis/java-bigtable/issues/2850)) ([fb437e0](https://togithub.com/googleapis/java-bigtable/commit/fb437e074ee328d57c00807d4afcaf26dd78aea7))


### Documentation

* **bigtable:** Expose Admin API Stubs in Javadoc ([#2835](https://togithub.com/googleapis/java-bigtable/issues/2835)) ([b7a0232](https://togithub.com/googleapis/java-bigtable/commit/b7a0232b1cf9639f5c529240482a99c94d950931))
* **bigtable:** Expose Base Admin Clients in Javadoc ([#2833](https://togithub.com/googleapis/java-bigtable/issues/2833)) ([2933ef6](https://togithub.com/googleapis/java-bigtable/commit/2933ef6419ec6ec6e3220a6bab03bb0c2cf7cd0d))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sushanb @igorbernstein2 @cleissonbarbosa @cloud-java-bot