Visitar URL original
docs: add new sample storage_configure_retries by BenWhitehead · Pull Request #1152 · googleapis/java-storage · GitHub
Skip to content
This repository was archived by the owner on Sep 25, 2026. It is now read-only.

docs: add new sample storage_configure_retries - #1152

Merged
BenWhitehead merged 2 commits into
googleapis:mainfrom
BenWhitehead:retry-samples
Jan 6, 2022
Merged

docs: add new sample storage_configure_retries#1152
BenWhitehead merged 2 commits into
googleapis:mainfrom
BenWhitehead:retry-samples

Conversation

@BenWhitehead

@BenWhitehead BenWhitehead commented Nov 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Outstanding items:

  • Libraries bom updated to a version which includes google-cloud-storage >= v2.2.0

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2021
@snippet-bot

snippet-bot Bot commented Nov 17, 2021 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Nov 17, 2021
@BenWhitehead
BenWhitehead marked this pull request as ready for review December 13, 2021 21:32
@BenWhitehead
BenWhitehead requested a review from a team December 13, 2021 21:33
@BenWhitehead BenWhitehead added owlbot:ignore instruct owl-bot to ignore a PR owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Dec 13, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 13, 2021
@BenWhitehead
BenWhitehead requested a review from a team December 13, 2021 21:39
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Dec 13, 2021
@BenWhitehead BenWhitehead added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Dec 13, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 13, 2021
tritone
tritone approved these changes Dec 16, 2021
View reviewed changes

@tritone tritone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java
.setMaxAttempts(10)
// to set the backoff multiplier to 3.0
.setRetryDelayMultiplier(3.0)
// to set the max duration of all attempts to 5 minutes

@tritone tritone Dec 16, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unrealistically long for a delete, but fine if this is what other langs have.

@BenWhitehead
BenWhitehead requested a review from cbonnie January 4, 2022 21:01
@BenWhitehead
BenWhitehead merged commit 8634c4b into googleapis:main Jan 6, 2022
@BenWhitehead
BenWhitehead deleted the retry-samples branch January 6, 2022 17:47
cbonnie
cbonnie reviewed Jan 6, 2022
View reviewed changes

@cbonnie cbonnie left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few edits, otherwise LGTM.

Comment thread samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Resolved
Comment thread samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Resolved
Comment thread samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Resolved
Comment thread samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Resolved
Comment thread samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Resolved
Comment thread samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Resolved
@BenWhitehead BenWhitehead mentioned this pull request Jan 6, 2022
Merged
@release-please release-please Bot mentioned this pull request Aug 10, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@cbonnie cbonnie cbonnie left review comments
@tritone tritone tritone approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eaball35 eaball35

Labels

api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

Retry Conformance Project

Development

Successfully merging this pull request may close these issues.

4 participants

@BenWhitehead @tritone @cbonnie @eaball35