Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces support for Model Context Protocol (MCP) transport in Dataproc integration tests. It refactors the existing test suite by creating a dataprocTransport abstraction to handle both legacy REST API and MCP-based tool invocations, and updates test methods to utilize this new transport. Additionally, a new test file tests/dataproc/dataproc_mcp_test.go has been added to verify MCP tool registry and endpoint functionality. I have no feedback to provide.
Description
This PR migrates the Dataproc integration tests to use the /mcp endpoint on the MCP
Toolbox Server.
Key Changes
dataproc_mcp_test.go: addsTestDataprocMCPListTools(validates thetools/listmanifest) andTestDataprocClustersMCPToolEndpoints(runs the same cluster and job checks as the legacy test over MCP, including auth: 200 with a valid token, 401 with an invalid or missing token; error cases are asserted as MCP error results).dataproc_integration_test.go: replacesinvokeToolwith a small REST/MCP transport so both tests run the same checks; the legacy assertions are unchanged.t.Cleanup, and REST requests use the test context.Testing
go vetpasses. The integration tests need Google Cloud credentials and existing clusters and jobs, so they will first run in CI via thedataprocshard.PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
review
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>