Visitar URL original
test(source/mindsdb): migrate integration tests to MCP endpoint by DylanVolz · Pull Request #4200 · googleapis/mcp-toolbox · GitHub
Skip to content

test(source/mindsdb): migrate integration tests to MCP endpoint - #4200

Open
DylanVolz wants to merge 1 commit into
googleapis:mainfrom
DylanVolz:chore/mindsdb-mcp-migration
Open

DylanVolz wants to merge 1 commit into
googleapis:mainfrom
DylanVolz:chore/mindsdb-mcp-migration

Conversation

@DylanVolz

Copy link
Copy Markdown

Description

This PR migrates the MindsDB integration tests to use the /mcp endpoint on the MCP Toolbox Server.

Key Changes

  • mindsdb_mcp_test.go: adds TestMindsDBMCPListTools (validates the tools/list
    manifest) and TestMindsDBMCPToolEndpoints (runs RunToolInvokeTest withWithMCP() and the same MindsDB SQL, integration, error-handling and auth checks as the legacy test over MCP).
  • mindsdb_integration_test.go: replaces the REST-only RunToolInvokeSimpleTest/RunToolInvokeParametersTest calls with a local REST/MCP transport so both tests run the same checks; the shared helpers in tests/tool.go are unchanged, and the legacy assertions are unchanged.
  • Cleanup hardening: the connection pool is closed, table drops are registered before the tables are created (with a bounded timeout), and REST requests use the test context.

Testing

go vet passes. The integration tests need a live MindsDB instance and a Google ID token, so they will first run in CI via the mindsdb shard.

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure you have manually reviewed the entire diff before requesting a
    review
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

@DylanVolz
DylanVolz requested a review from a team as a code owner September 30, 2026 17:16
@google-cla

google-cla Bot commented Sep 30, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the MindsDB integration tests to support both the legacy REST API and the Model Context Protocol (MCP) transports. It introduces a mindsDBTransport helper to abstract tool invocation and server management, and adds a new test suite in mindsdb_mcp_test.go to verify MindsDB MCP tool listing and execution. I have no feedback to provide as there are no review comments.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants