Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request refactors the MindsDB integration tests to support both the legacy REST API and the Model Context Protocol (MCP) transports. It introduces a mindsDBTransport helper to abstract tool invocation and server management, and adds a new test suite in mindsdb_mcp_test.go to verify MindsDB MCP tool listing and execution. I have no feedback to provide as there are no review comments.
Description
This PR migrates the MindsDB integration tests to use the /mcp endpoint on the MCP Toolbox Server.
Key Changes
mindsdb_mcp_test.go: addsTestMindsDBMCPListTools(validates thetools/listmanifest) and
TestMindsDBMCPToolEndpoints(runsRunToolInvokeTestwithWithMCP()and the same MindsDB SQL, integration, error-handling and auth checks as the legacy test over MCP).mindsdb_integration_test.go: replaces the REST-onlyRunToolInvokeSimpleTest/RunToolInvokeParametersTestcalls with a local REST/MCP transport so both tests run the same checks; the shared helpers intests/tool.goare unchanged, and the legacy assertions are unchanged.Testing
go vetpasses. The integration tests need a live MindsDB instance and a Google ID token, so they will first run in CI via themindsdbshard.PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
review
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>