Visitar URL original
feat: add automatic logging config to support debug logging by ohmayr · Pull Request #754 · googleapis/python-api-core · GitHub
Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: add automatic logging config to support debug logging - #754

Merged
parthea merged 18 commits into
mainfrom
debug-logging
Dec 2, 2024
Merged

feat: add automatic logging config to support debug logging#754
parthea merged 18 commits into
mainfrom
debug-logging

Conversation

@ohmayr

@ohmayr ohmayr commented Nov 4, 2024 •
edited by parthea
Loading

Copy link
Copy Markdown
Contributor

Implement automatic logging config to allow users to enable debug logging via an environment variable.

Fixes b/381099872

@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Nov 4, 2024
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 11, 2024
vchudnov-g
vchudnov-g reviewed Nov 22, 2024
View reviewed changes
Comment thread google/api_core/client_logging.py Resolved
Comment thread google/api_core/client_logging.py Resolved
Comment thread google/api_core/client_logging.py Resolved
Comment thread google/api_core/client_logging.py Resolved
Comment thread tests/unit/test_client_logging.py Resolved
Comment thread tests/unit/test_client_logging.py Resolved
@ohmayr ohmayr changed the title feat: add base logger to enable debug logging feat: add automatic logging config to support debug logging Nov 25, 2024
vchudnov-g
vchudnov-g reviewed Nov 26, 2024
View reviewed changes
Comment thread google/api_core/client_logging.py Resolved
Comment thread tests/unit/test_client_logging.py Resolved
Comment thread google/api_core/client_logging.py Resolved
Comment thread tests/unit/test_client_logging.py Resolved
Comment thread tests/unit/test_client_logging.py Resolved
Comment thread tests/unit/test_client_logging.py Resolved
@ohmayr
ohmayr marked this pull request as ready for review November 26, 2024 18:48
@ohmayr
ohmayr requested review from a team November 26, 2024 18:48
parthea
parthea reviewed Nov 26, 2024
View reviewed changes
Comment thread google/api_core/client_logging.py Resolved
parthea
parthea reviewed Nov 26, 2024
View reviewed changes
Comment thread google/api_core/client_logging.py Resolved
parthea
parthea reviewed Nov 26, 2024
View reviewed changes
Comment thread google/api_core/client_logging.py Resolved
parthea
parthea reviewed Nov 26, 2024
View reviewed changes
Comment thread google/api_core/client_logging.py Resolved
vchudnov-g
vchudnov-g reviewed Nov 26, 2024
View reviewed changes
Comment thread google/api_core/client_logging.py Resolved
Comment thread google/api_core/client_logging.py Resolved
Comment thread tests/unit/test_client_logging.py Resolved
Comment thread tests/unit/test_client_logging.py Resolved
Comment thread tests/unit/test_client_logging.py Resolved
Comment thread tests/unit/test_client_logging.py Resolved
Comment thread google/api_core/client_logging.py Resolved
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 27, 2024
parthea
parthea reviewed Nov 27, 2024
View reviewed changes
Comment thread google/api_core/client_logging.py Resolved
Comment thread google/api_core/client_logging.py Resolved
Comment thread google/api_core/client_logging.py Resolved
parthea
parthea reviewed Nov 28, 2024
View reviewed changes
Comment thread google/api_core/client_logging.py
# Fields to be included in the StructuredLogFormatter.
#
# TODO(https://github.com/googleapis/python-api-core/issues/761): Update this list to support additional logging fields.
_recognized_logging_fields = [

@parthea parthea Nov 28, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to note is that users will need to update google-api-core to get any additional logging fields in the future.

@ohmayr ohmayr Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true. Any fields that we add in the future will require users to update google-api-core.

parthea
parthea reviewed Nov 28, 2024
View reviewed changes
Comment thread google/api_core/client_logging.py Resolved
Comment thread google/api_core/client_logging.py Resolved
@parthea
parthea merged commit d18d9b5 into main Dec 2, 2024
@parthea
parthea deleted the debug-logging branch December 2, 2024 11:12
@release-please release-please Bot mentioned this pull request Dec 2, 2024
Merged
This was referenced May 30, 2025
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@parthea parthea parthea approved these changes
@vchudnov-g vchudnov-g vchudnov-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@parthea parthea

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ohmayr @parthea @vchudnov-g