Visitar URL original
chore!: remove google.cloud.bigquery_v2 code by plamut · Pull Request #855 · googleapis/python-bigquery · GitHub
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore!: remove google.cloud.bigquery_v2 code - #855

Merged
gcf-merge-on-green[bot] merged 34 commits into
googleapis:v3from
plamut:iss-814
Sep 27, 2021
Merged

chore!: remove google.cloud.bigquery_v2 code#855
gcf-merge-on-green[bot] merged 34 commits into
googleapis:v3from
plamut:iss-814

Conversation

@plamut

@plamut plamut commented Aug 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #814.

The first preview. Still need to address Model types, disable code generation, BigQuery ML classes...

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2021
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 6, 2021
@plamut
plamut force-pushed the iss-814 branch 4 times, most recently from 386a8bf to bc48efc Compare August 13, 2021 12:56
@plamut
plamut force-pushed the iss-814 branch 3 times, most recently from 04562dd to 363eef5 Compare August 20, 2021 09:56
@plamut
plamut marked this pull request as ready for review August 20, 2021 14:43
@plamut
plamut requested a review from a team August 20, 2021 14:43
@plamut
plamut requested a review from a team as a code owner August 20, 2021 14:43
@plamut
plamut requested review from a team, kurtisvg and stephaniewang526 August 20, 2021 14:43
@plamut

plamut commented Aug 20, 2021

Copy link
Copy Markdown
Contributor Author

This is now ready for review.

It's probably easier to review commit-by-commit, as I made the effort to keep commits mostly self-contained and independent from each other.

@plamut
plamut requested a review from tswast August 20, 2021 14:45
kurtisvg
kurtisvg approved these changes Aug 20, 2021
View reviewed changes

@kurtisvg kurtisvg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for /samples.

tswast
tswast reviewed Sep 17, 2021
View reviewed changes
Comment thread samples/tests/conftest.py
name="x",
data_type=bigquery_v2.types.StandardSqlDataType(
type_kind=bigquery_v2.types.StandardSqlDataType.TypeKind.INT64
data_type=bigquery.StandardSqlDataType(

@tswast tswast Sep 17, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we mention these changes to Standard SQL types and enums in the migration guide. #960

@plamut plamut Sep 20, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely

@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2021
plamut
plamut commented Sep 22, 2021
View reviewed changes
Comment thread google/cloud/bigquery/schema.py Resolved
plamut
plamut commented Sep 22, 2021
View reviewed changes
Comment thread google/cloud/bigquery/standard_sql.py Resolved
@plamut
Remove validation logic from StandardSqlDataType
1b29ac2 
Client-side validation logic can drift away from the server's, thus
we let the backend perform all validation of submitted request data.
@plamut
Refactor SQL models to use shared state
adcaa03 
Modifying a sub-type should be automatically reflected on the parent
type referencing that subtype.
@plamut

plamut commented Sep 23, 2021

Copy link
Copy Markdown
Contributor Author

@tswast Pushed the implementation changes early for preview, but there are now only a few coverage misses left, thus this is close to done.

tswast
tswast reviewed Sep 23, 2021
View reviewed changes

@tswast tswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once coverage is there, with some small nits re: setup.py and owlbot.

Comment thread docs/conf.py Resolved
Comment thread setup.py Resolved
@plamut
plamut requested a review from tswast September 24, 2021 08:35
@plamut plamut mentioned this pull request Sep 27, 2021
Closed
tswast
tswast approved these changes Sep 27, 2021
View reviewed changes
Comment thread google/cloud/bigquery/model.py Resolved
@tswast

tswast commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Thanks!

@plamut plamut added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2021
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit a7842b6 into googleapis:v3 Sep 27, 2021
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 27, 2021
@plamut
plamut deleted the iss-814 branch September 28, 2021 14:49
@plamut plamut mentioned this pull request Oct 1, 2021
Closed
6 tasks done
@tswast tswast mentioned this pull request Aug 15, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526
2 more reviewers
@tswast tswast tswast approved these changes
@kurtisvg kurtisvg kurtisvg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@plamut @tswast @kurtisvg @yoshi-kokoro