Visitar URL original
feat: Proto Columns Feature by harshachinta · Pull Request #909 · googleapis/python-spanner · GitHub
Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: Proto Columns Feature - #909

Merged
surbhigarg92 merged 17 commits into
googleapis:proto-column-enhancement-alphafrom
harshachinta:proto-col-implementation
Mar 27, 2023
Merged

feat: Proto Columns Feature#909
surbhigarg92 merged 17 commits into
googleapis:proto-column-enhancement-alphafrom
harshachinta:proto-col-implementation

Conversation

@harshachinta

@harshachinta harshachinta commented Mar 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds code changes for Proto Columns feature support in Python Client along with sample snippets.

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Mar 7, 2023
asthamohta
asthamohta reviewed Mar 14, 2023
View reviewed changes
Comment thread google/cloud/spanner_v1/_helpers.py
asthamohta
asthamohta reviewed Mar 14, 2023
View reviewed changes
Comment thread google/cloud/spanner_v1/_helpers.py Outdated
asthamohta
asthamohta reviewed Mar 14, 2023
View reviewed changes
Comment thread google/cloud/spanner_v1/_helpers.py
asthamohta
asthamohta reviewed Mar 14, 2023
View reviewed changes
Comment thread google/cloud/spanner_v1/_helpers.py
asthamohta
asthamohta reviewed Mar 14, 2023
View reviewed changes
Comment thread google/cloud/spanner_v1/data_types.py Outdated
asthamohta
asthamohta reviewed Mar 14, 2023
View reviewed changes
Comment thread google/cloud/spanner_v1/param_types.py Outdated
asthamohta
asthamohta reviewed Mar 14, 2023
View reviewed changes
Comment thread google/cloud/spanner_v1/param_types.py Outdated
asthamohta
asthamohta reviewed Mar 14, 2023
View reviewed changes
Comment thread samples/samples/snippets.py Outdated
asthamohta
asthamohta reviewed Mar 14, 2023
View reviewed changes
Comment thread samples/samples/snippets.py
asthamohta
asthamohta reviewed Mar 14, 2023
View reviewed changes
Comment thread samples/samples/testdata/singer_pb2.py
@harshachinta
harshachinta requested a review from asthamohta March 14, 2023 14:41
@harshachinta
harshachinta marked this pull request as ready for review March 20, 2023 18:19
@harshachinta
harshachinta requested a review from a team as a code owner March 20, 2023 18:19
@harshachinta
harshachinta requested review from a team and engelke and removed request for a team March 20, 2023 18:19
@snippet-bot

snippet-bot Bot commented Mar 20, 2023 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

gauravpurohit06
gauravpurohit06 suggested changes Mar 23, 2023
View reviewed changes
Comment thread google/cloud/spanner_v1/data_types.py
Comment thread google/cloud/spanner_v1/_helpers.py
Comment thread samples/samples/snippets.py
gauravpurohit06
gauravpurohit06 suggested changes Mar 24, 2023
View reviewed changes
Comment thread google/cloud/spanner_v1/session.py Outdated
Comment thread google/cloud/spanner_v1/snapshot.py Outdated
gauravpurohit06
gauravpurohit06 approved these changes Mar 27, 2023
View reviewed changes

@gauravpurohit06 gauravpurohit06 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, As discussed offline just remove the tags from the additional samples which we don't want to publish.

@surbhigarg92
surbhigarg92 merged commit 7fd2f90 into googleapis:proto-column-enhancement-alpha Mar 27, 2023
harshachinta added a commit that referenced this pull request May 16, 2024
@harshachinta @gcf-owl-bot
feat(spanner): add support for Proto Columns (#1084)
3ca2689 
* feat: Proto Columns Feature (#909)

* feat: adding proto autogenerated code changes for proto column feature

* feat: add implementation for Proto columns DDL

* feat: add implementation for Proto columns DML

* feat: add implementation for Proto columns DQL

* feat: add NoneType check during Proto deserialization

* feat: add code changes for Proto DDL support

* feat: add required proto files to execute samples and tests

* feat: add sample snippets for Proto columns DDL

* feat: add tests for proto columns ddl, dml, dql snippets

* feat: code refactoring

* feat: remove staging endpoint from snippets.py

* feat: comment refactor

* feat: add license file

* feat: update proto column data in insertion sample

* feat: move column_info argument to the end to avoid breaking code

* feat: Proto column feature tests and samples (#921)

* feat: add integration tests for Proto Columns

* feat: add unit tests for Proto Columns

* feat: update tests to add column_info argument at end

* feat: remove deepcopy during deserialization of proto message

* feat: tests refactoring

* feat: integration tests refactoring

* feat: samples and sample tests refactoring

* feat: lint tests folder

* feat:lint samples directory

* feat: stop running emulator with proto ddl commands

* feat: close the file after reading

* feat: update protobuf version lower bound to >3.20 to check proto message compatibility

* feat: update setup for snippets_tests.py file

* feat: add integration tests

* feat: remove duplicate integration tests

* feat: add proto_descriptor parameter to required tests

* feat: add compatibility tests between Proto message, Bytes and Proto Enum, Int64

* feat: add index tests for proto columns

* feat: replace duplicates with sample data

* feat: update protobuf lower bound version in setup.py file to add support for proto messages and enum

* feat: lint fixes

* feat: lint fix

* feat: tests refactoring

* feat: change comment from dml to dql for read

* feat: tests refactoring for update db operation

* feat: rever autogenerated code

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: fix code

* fix: fix code

* fix(spanner): fix code

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix(spanner): skip emulator due to b/338557401

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix(spanner): remove samples

* fix(spanner): update coverage

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore(spanner): update coverage

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix(spanner): add samples and update proto schema

* fix(spanner): update samples database and emulator DDL

* fix(spanner): update admin test to use autogenerated interfaces

* fix(spanner): comment refactoring

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@engelke engelke Awaiting requested review from engelke engelke was automatically assigned from googleapis/python-samples-reviewers
2 more reviewers
@gauravpurohit06 gauravpurohit06 gauravpurohit06 approved these changes
@asthamohta asthamohta asthamohta approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harshachinta @gauravpurohit06 @asthamohta @surbhigarg92