Make signing plugin support the configuration cache

This issue is about making the signing core Gradle plugin support the configuration cache.

Upon completion, all configuration and tasks provided by the signing plugin are compatible with the configuration cache.

Fix configuration cache issues with install task

I also like the feature of #16056 to use a Credential class as configuration instead.

What does using a Credentialclass brings compared to useInMemoryPgpKeys? In both cases, Gradle would need some logic to not persist the keys and since most CIs use environment variables, I kind of like the simplicity of useInMemoryPgpKeys(System.getenv("KEY"), System.getenv("PASSWORD"))

Mostly a common expected variable name aligned with RepositoryCredentials and Sonatype Publishing Credentials:

ORG_GRADLE_PROJECT_myMavenRepoUsername
ORG_GRADLE_PROJECT_sonatypeUsername

ORG_GRADLE_PROJECT_signingUsername // for example

etc.
And the option to implement your own credential class 🤷🏻‍♂️

But more important is open question of the cache..

Gotcha.

But more important is open question of the cache..

Agreed 👍

@martinbonnin

@martinbonnin this sounded to me like when something is obtained through the credential API it wouldn't be persisted in the cache https://docs.gradle.org/7.6/userguide/configuration_cache.html#config_cache:requirements:safe_credentials

Exclude all `Sign` tasks from configuration-cache test

Navigation Menu

Repository navigation

Make `signing` plugin support the configuration cache #13470

26 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Make signing plugin support the configuration cache #13470

Description

Activity

26 remaining items

martinbonnin commented on Jan 17, 2023

hfhbd commented on Jan 17, 2023

martinbonnin commented on Jan 17, 2023

gabrielittner commented on Jan 17, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Make `signing` plugin support the configuration cache #13470