Repository navigation
ghcide: Log which implicit cradle is used when there is no hie.yaml - #5159
Open
RyosukeDTomita wants to merge 2 commits into
Open
RyosukeDTomita wants to merge 2 commits into
RyosukeDTomita wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Hi! I think changing |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`fix 4575
AI Policy
I used it as a research aid while investigating the issue, and then had it
review the changes as an additional pair of eyes. However, I wrote all of
the code myself.
write the English text (commit messages, comments, and this description).
I have carefully reviewed all submitted material and take full responsibility
for it under GHC Policy on LLM contributions (P3).
Fix
When no
hie.yamlis found,loadImplicitCradlenow logs at INFO level which implicit cradle was inferred, or that it fell back to the default cradle.How I tested
no
hie.yaml, withcabal.projectand a.cabalfilebefore
Details
log all outputafter
I find new log output.
all log output
Something I'd like to discuss
I kept this change minimal and would like your opinion before going further.
Should we also log the branches that did not match (e.g. "no stack.yaml found", "no .cabal file found")?
I am considering the following two options.
inferCradleTreeable to log.inferCradleTreereturn the patterns it tried along with the result, and log them fromloadImplicitCradle.