Visitar URL original
ci: auto-label PRs targeting dev-v3 by benoittgt · Pull Request #32340 · helm/helm · GitHub
Skip to content

ci: auto-label PRs targeting dev-v3 - #32340

Merged
TerryHowe merged 4 commits into
helm:dev-v3from
benoittgt:ci/tag-dev-v3
Jul 15, 2026
Merged

TerryHowe merged 4 commits into
helm:dev-v3from
benoittgt:ci/tag-dev-v3

Conversation

@benoittgt

@benoittgt benoittgt commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Use actions/labeler to automatically apply a "v3.x" label on PRs opened against the dev-v3 branch, so we do not need to do it manually, change the PR name to include [dev-v3], or risk forgetting altogether...

Special notes for your reviewer:

Made using Claude Opus 4-6, reviewed with Zizmor. There are a few issues flagged, but none introduced by the code I added.

I'm not sure whether this addition is part of a broader change.

  • Create this label !

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 13, 2026
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/labeler@b8dd2d9be0f68b860e7dae5dae7d772984eacd6d # pin@v6.2.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TerryHowe
TerryHowe previously approved these changes Jul 13, 2026

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe added the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Jul 13, 2026
@benoittgt
benoittgt marked this pull request as ready for review July 13, 2026 16:36
Copilot AI review requested due to automatic review settings July 13, 2026 16:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds GitHub Actions label automation so PRs targeting the dev-v3 branch are labeled consistently, reducing manual triage work in this repo’s contribution workflow.

Changes:

  • Introduce a new pull_request_target workflow that runs actions/labeler to manage PR labels.
  • Add a labeler configuration mapping to apply the dev-v3 label based on the PR base branch.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/label-pr.yml New workflow to run actions/labeler with minimal permissions to label PRs.
.github/labeler.yml Labeler rules to apply the dev-v3 label when the PR targets dev-v3.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/label-pr.yml Resolved
Copilot AI review requested due to automatic review settings July 13, 2026 16:42
Comment thread .github/labeler.yml Outdated
@@ -0,0 +1,2 @@
"dev-v3":

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to create this label.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that should be v3.x?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, lets use v3.x, as this label already exists: https://github.com/helm/helm/pulls?q=label%3Av3.x

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread .github/workflows/label-pr.yml Resolved
Comment on lines +2 to +5
on:
pull_request_target:
branches: [dev-v3]
types: [opened, reopened, edited, synchronize]

@gjenkins8 gjenkins8 Jul 14, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we will need to apply these changes to dev-v3 branch I would expect.

But I think we should create a separate PR do the same/similar for main and label with v4.x

Comment thread .github/labeler.yml Outdated
Comment on lines +1 to +2
"dev-v3":
- base-branch: "dev-v3"

@gjenkins8 gjenkins8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use the existing v3.x label, and figure out if this PR should be against dev-v3 or main please.

(I also do think the equivalent change for main to the v4.x label would be great)

Copilot AI review requested due to automatic review settings July 15, 2026 14:08
@benoittgt

Copy link
Copy Markdown
Contributor Author

(I also do think the equivalent change for main to the v4.x label would be great)

Good idea. I will make another PR after this one.

@benoittgt
benoittgt changed the base branch from main to dev-v3 July 15, 2026 14:08
benoittgt and others added 3 commits July 15, 2026 16:10
Use actions/labeler to apply a "dev-v3" label on PRs
opened against the `dev-v3` branch.

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Avoid creating a new label since v3.x already exists in the repo

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread .github/labeler.yml Resolved
Comment thread .github/workflows/label-pr.yml Resolved
@gjenkins8
gjenkins8 requested a review from TerryHowe July 15, 2026 22:21
@gjenkins8

Copy link
Copy Markdown
Member

Thanks!

(now just need to wait for @TerryHowe or another maintainer for second approval)

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe
TerryHowe merged commit c9ed0ca into helm:dev-v3 Jul 15, 2026
5 checks passed
@TerryHowe

Copy link
Copy Markdown
Contributor

Thanks!

gjenkins8 pushed a commit that referenced this pull request Jul 19, 2026
Mirrors the dev-v3 labeling workflow from #32340, reusing the
existing v4.x label since main tracks the upcoming v4 release.

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
@scottrigby scottrigby removed the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants