Visitar URL original
fix: set [pull,push] scope when helm push to a registry(use token auth) (backport) by kimsungmin1 · Pull Request #32362 · helm/helm · GitHub
Skip to content

fix: set [pull,push] scope when helm push to a registry(use token auth) (backport) - #32362

Merged
scottrigby merged 9 commits into
helm:dev-v3from
kimsungmin1:dev-v3-fix-push-scope
Aug 31, 2026
Merged

fix: set [pull,push] scope when helm push to a registry(use token auth) (backport)#32362
scottrigby merged 9 commits into
helm:dev-v3from
kimsungmin1:dev-v3-fix-push-scope

Conversation

@kimsungmin1

@kimsungmin1 kimsungmin1 commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
this is reopen of #31129
and backport of #31211

Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@kimsungmin1
set [pull,push] scope when helm push
3d199c3 
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
@kimsungmin1
add a validation for push scope setting, add some test code to check …
5923879 
…the scope when registry use token auth

Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
@kimsungmin1
eliminate gin-gonic dependency in client_scope_test.go test code
66b126d 
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
@kimsungmin1
change the parameter order in suite.Equal in client_scope_test.go code
8054ef6 
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
@kimsungmin1
add license header in client_scope_test.go file
6e08aaa 
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
@kimsungmin1
move variable location
08c4928 
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
@kimsungmin1
Merge branch 'dev-v3' of https://github.com/helm/helm into dev-v3-fix…
f43e08b 
…-push-scope
@kimsungmin1
remove freeport dependency
b8edb5d 
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
@kimsungmin1
Merge branch 'dev-v3' of https://github.com/helm/helm into dev-v3-fix…
07b13b6 
…-push-scope

Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>

# Conflicts:
#	go.mod
#	pkg/registry/utils_test.go
@pull-request-size pull-request-size Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2026
@Techassi Techassi mentioned this pull request Aug 26, 2026
Closed
TerryHowe
TerryHowe approved these changes Aug 28, 2026
View reviewed changes

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe added the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Aug 28, 2026
scottrigby
scottrigby approved these changes Aug 31, 2026
View reviewed changes

@scottrigby scottrigby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scottrigby
scottrigby merged commit 9dbcb9f into helm:dev-v3 Aug 31, 2026
5 checks passed
@scottrigby scottrigby added bug Categorizes issue or PR as related to a bug. and removed Has One Approval This PR has one approval. It still needs a second approval to be merged. labels Aug 31, 2026
@scottrigby scottrigby added this to the 3.22.0 milestone Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TerryHowe TerryHowe TerryHowe approved these changes
@scottrigby scottrigby scottrigby approved these changes

Assignees

No one assigned

Labels

bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

3.22.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kimsungmin1 @TerryHowe @scottrigby