Visitar URL original
Switch to actions/setup-java's built-in cache by steven-sheehy · Pull Request #2481 · hiero-ledger/hiero-mirror-node · GitHub
Skip to content

Switch to actions/setup-java's built-in cache - #2481

Merged
steven-sheehy merged 1 commit into
mainfrom
java-cache
Aug 31, 2021
Merged

steven-sheehy merged 1 commit into
mainfrom
java-cache

Conversation

@steven-sheehy

@steven-sheehy steven-sheehy commented Aug 31, 2021 •

Copy link
Copy Markdown
Contributor

Description:

  • Switch from actions/cache to the new built-in cache in actions/setup-java
  • Fix some workflows using mvnw without explicitly installing Java

Related issue(s):

Notes for reviewer:
Besides simpler config syntax, it also provides build performance improvements by installing java and dependencies in parallel.

Presumably the VM has a built in java. That's why it worked previously without an explicit setup-java.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added enhancement Type: New feature process Build or test related tasks labels Aug 31, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.40.0 milestone Aug 31, 2021
@steven-sheehy steven-sheehy self-assigned this Aug 31, 2021
@codecov

codecov Bot commented Aug 31, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #2481 (f81b12d) into main (3b355cc) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2481   +/-   ##
=========================================
  Coverage     91.56%   91.57%           
  Complexity     2536     2536           
=========================================
  Files           420      420           
  Lines         11598    11598           
  Branches       1018     1018           
=========================================
+ Hits          10620    10621    +1     
  Misses          645      645           
+ Partials        333      332    -1     
Impacted Files Coverage Δ
...a/mirror/grpc/listener/CompositeTopicListener.java 84.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b355cc...f81b12d. Read the comment docs.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@steven-sheehy
steven-sheehy marked this pull request as ready for review August 31, 2021 21:52
@steven-sheehy
steven-sheehy requested a review from a team August 31, 2021 21:52

@ijungmann ijungmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xin-hedera xin-hedera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy
steven-sheehy merged commit e975816 into main Aug 31, 2021
@steven-sheehy
steven-sheehy deleted the java-cache branch August 31, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type: New feature process Build or test related tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants