Repository navigation
fix(session): session.invoke running through a loop of length zero - #81
Open
ViktoriaSchubert42 wants to merge 1 commit into
Open
ViktoriaSchubert42 wants to merge 1 commit into
ViktoriaSchubert42 wants to merge 1 commit into
Conversation
> > In 'hydrogram/session/session.py' in the session's class function 'invoke' the function is executing a while loop over the amount of retries, which is defined as 'retries: int = MAX_RETRIES,'(line424). Using 'hydrogram/methods/bots/request_callback_answer.py' defines the retries as: 'retries=0,', meaning that an action should be executed once without retrying. The problem is that in session's invoke function, the loop is over the number of retries, not the number of actual tries + retries. A variable 'tries = retries + 1' was added and the while loop is now running over the number of tries, which shall always be 1 actual try plus the number of retries, not just the number of retries that was set
|
@alissonlauffer, please review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 'hydrogram/session/session.py' in the session's class function 'invoke' the function is executing a while loop over the amount of retries, which is defined as 'retries: int = MAX_RETRIES,'(line424). Using 'hydrogram/methods/bots/request_callback_answer.py' defines the retries as: 'retries=0,', meaning that an action should be executed once without retrying. The problem is that in session's invoke function, the loop is over the number of retries, not the number of actual tries + retries. A variable 'tries = retries + 1' was added and the while loop is now running over the number of tries, which shall always be 1 actual try plus the number of retries, not just the number of retries that was set