Visitar URL original
Add null default for old gitlab runnerToken flow (#1491) by SamKnightGit · Pull Request #1492 · iterative/cml · GitHub
Skip to content

Add null default for old gitlab runnerToken flow (#1491) - #1492

Open
SamKnightGit wants to merge 1 commit into
iterative:mainfrom
SamKnightGit:fix-gitlab-runnertoken
Open

SamKnightGit wants to merge 1 commit into
iterative:mainfrom
SamKnightGit:fix-gitlab-runnertoken

Conversation

@SamKnightGit

Copy link
Copy Markdown
Contributor

When legacy gitlab runner registration token is disabled old flow returns an undefined token which causes the null check to enter the new token code path to fail.

Tested runner-token e2e test with the following cases on a local gitlab repository:

  • Pre change w/ legacy runner registration enabled:
    • runnerToken returned via legacy code path is valid, test passes.
  • Pre change w/ legacy runner registration disabled:
    • runnerToken returned is undefined when executing legacy code path and test fails on output.length.
  • Post change w/ legacy runner registration enabled:
    • runnerToken returned via legacy code path is valid, test passes.
  • Post change w/ legacy runner registration disabled:
    • runnerToken returned is null when executing legacy code path, new token code path is entered via null check and valid runner token is received.

Not sure how to incorporate these tests into the CML repo without setting up additional test repos...

When legacy gitlab runner registration token is disabled
old flow returns an undefined token which causes the
null check to enter the new token code path to fail.

This branch had an error being deployed

1 failed deployment
external — 0a847260 Deployed Jun 9, 2025 by SamKnightGit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant