Visitar URL original
Global object by vplentinax · Pull Request #181 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Global object - #181

Merged
EzequielCaste merged 10 commits into
javascript-tutorial:masterfrom
vplentinax:global-object
Jun 24, 2020
Merged

Global object#181
EzequielCaste merged 10 commits into
javascript-tutorial:masterfrom
vplentinax:global-object

Conversation

@vplentinax

@vplentinax vplentinax commented May 11, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a team May 11, 2020 22:54
@iliakan iliakan mentioned this pull request May 11, 2020
Open
joaquinelio
joaquinelio requested changes Jun 24, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tá güeno.
-Espacios de más
-1 título dudoso
-Me pareció que alternas entre el tú y el usted... No me importa, pero deberíamos ser consistentes ¿qué usamos?

Comment thread 1-js/06-advanced-functions/05-global-object/article.md Outdated
Comment thread 1-js/06-advanced-functions/05-global-object/article.md Outdated
Comment thread 1-js/06-advanced-functions/05-global-object/article.md Outdated
Comment thread 1-js/06-advanced-functions/05-global-object/article.md Outdated
Comment thread 1-js/06-advanced-functions/05-global-object/article.md Outdated
Comment thread 1-js/06-advanced-functions/05-global-object/article.md Outdated
Comment thread 1-js/06-advanced-functions/05-global-object/article.md Outdated
Comment thread 1-js/06-advanced-functions/05-global-object/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 24, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinax and others added 8 commits June 24, 2020 11:54
@vplentinax @joaquinelio
Update 1-js/06-advanced-functions/05-global-object/article.md
bd8d026 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/06-advanced-functions/05-global-object/article.md
4dc5c34 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/06-advanced-functions/05-global-object/article.md
da03b27 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/06-advanced-functions/05-global-object/article.md
cd63810 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/06-advanced-functions/05-global-object/article.md
5bebd2d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/06-advanced-functions/05-global-object/article.md
f5dcbb3 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/06-advanced-functions/05-global-object/article.md
f0a887a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/06-advanced-functions/05-global-object/article.md
adbe14c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax

vplentinax commented Jun 24, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team June 24, 2020 16:03
EzequielCaste
EzequielCaste approved these changes Jun 24, 2020
View reviewed changes

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@EzequielCaste
EzequielCaste merged commit 802d106 into javascript-tutorial:master Jun 24, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 24, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio requested changes
@EzequielCaste EzequielCaste EzequielCaste approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vplentinax @javascript-translate-bot @joaquinelio @EzequielCaste