Visitar URL original
Promise by cortizg · Pull Request #188 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Promise - #188

Closed
cortizg wants to merge 2 commits into
javascript-tutorial:masterfrom
cortizg:es.javascript.info.1-11-02-p
Closed

Promise#188
cortizg wants to merge 2 commits into
javascript-tutorial:masterfrom
cortizg:es.javascript.info.1-11-02-p

Conversation

@cortizg

@cortizg cortizg commented May 13, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@cortizg
1-11-02-p Traducido 10
a06a45b 
corregido detalles

corregido typo
@javascript-translate-bot
javascript-translate-bot requested a review from a team May 13, 2020 08:40
@iliakan iliakan mentioned this pull request May 13, 2020
Open
joaquinelio
joaquinelio requested changes Jun 29, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo borrado. no puedo hacer suggest (dejé 3 comments)
@cortizg
Cambios menores, podés ignorarlos y pedir merge...
aunque no creo, son más estrictos que yo

Falta 1/11/2/2 solution, un solo renglón
typo
acento
elegir 1 palabra por consistencia /manejador/controlador/

EDIT: por qué hojarasca sale la letra dl coment tan grande si no puse ninguna decoracion

Comment thread 1-js/11-async/02-promise-basics/article.md
Comment thread 1-js/11-async/02-promise-basics/article.md
Comment thread 1-js/11-async/02-promise-basics/article.md
@javascript-translate-bot

javascript-translate-bot commented Jun 29, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@cortizg

cortizg commented Jun 29, 2020

Copy link
Copy Markdown
Contributor Author

Repo borrado. no puedo hacer suggest (dejé 3 comments)

@cortizg
Cambios menores, podés ignorarlos y pedir merge...
aunque no creo, son más estrictos que yo

Falta 1/11/2/2 solution, un solo renglón

typo
acento
elegir 1 palabra por consistencia /manejador/controlador/

EDIT: por qué hojarasca sale la letra dl coment tan grande si no puse ninguna decoracion

Tendré que cerrar el PR y subirlo de nuevo el branch

@cortizg

cortizg commented Jun 29, 2020

Copy link
Copy Markdown
Contributor Author

Cerrado por falta de branch

@cortizg cortizg closed this Jun 29, 2020
@cortizg cortizg mentioned this pull request Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio requested changes

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cortizg @javascript-translate-bot @joaquinelio