Visitar URL original
Constructor, operator "new" by EzequielCaste · Pull Request #273 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Constructor, operator "new" - #273

Merged
EzequielCaste merged 10 commits into
javascript-tutorial:masterfrom
EzequielCaste:Object.keys-values-entries
Jul 1, 2020
Merged

Constructor, operator "new"#273
EzequielCaste merged 10 commits into
javascript-tutorial:masterfrom
EzequielCaste:Object.keys-values-entries

Conversation

@EzequielCaste

@EzequielCaste EzequielCaste commented Jun 22, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a team June 22, 2020 20:10
@iliakan iliakan mentioned this pull request Jun 22, 2020
Open
@EzequielCaste EzequielCaste changed the title Object.keys, values, entries Constructor, operator "new" Jun 22, 2020
@EzequielCaste

EzequielCaste commented Jun 22, 2020

Copy link
Copy Markdown
Contributor Author

el commit tiene mal el nombre pero es para la traducción de "Constructor, operator "new""

cortizg
cortizg suggested changes Jun 28, 2020
View reviewed changes

@cortizg cortizg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buena traducción, Full review, algunos typos, comentarios

Comment thread 1-js/04-object-basics/06-constructor-new/2-calculator-constructor/_js.view/test.js Outdated
Comment thread 1-js/04-object-basics/06-constructor-new/3-accumulator/task.md Outdated
Comment thread 1-js/04-object-basics/06-constructor-new/3-accumulator/task.md Outdated
Comment thread 1-js/04-object-basics/06-constructor-new/3-accumulator/task.md Outdated
Comment thread 1-js/04-object-basics/06-constructor-new/article.md Outdated
Comment thread 1-js/04-object-basics/06-constructor-new/article.md Outdated
Comment thread 1-js/04-object-basics/06-constructor-new/article.md Outdated
Comment thread 1-js/04-object-basics/06-constructor-new/article.md Outdated
Comment thread 1-js/04-object-basics/06-constructor-new/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 28, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@cortizg

cortizg commented Jun 28, 2020

Copy link
Copy Markdown
Contributor

/done

@EzequielCaste
EzequielCaste removed the request for review from joaquinelio June 28, 2020 13:23
EzequielCaste and others added 9 commits June 28, 2020 10:24
@EzequielCaste @cortizg
Update 1-js/04-object-basics/06-constructor-new/2-calculator-construc…
9e6442f 
…tor/_js.view/test.js

Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste @cortizg
Update 1-js/04-object-basics/06-constructor-new/article.md
e7d5068 
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste
Update 1-js/04-object-basics/06-constructor-new/article.md
993dea0
@EzequielCaste @cortizg
Update 1-js/04-object-basics/06-constructor-new/article.md
381668b 
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste @cortizg
Update 1-js/04-object-basics/06-constructor-new/article.md
0e4a7c7 
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste
Update 1-js/04-object-basics/06-constructor-new/article.md
619b0cb
@EzequielCaste @cortizg
Update 1-js/04-object-basics/06-constructor-new/3-accumulator/task.md
23c506a 
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste @cortizg
Update 1-js/04-object-basics/06-constructor-new/3-accumulator/task.md
3d556ea 
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste @cortizg
Update 1-js/04-object-basics/06-constructor-new/3-accumulator/task.md
a6dbf35 
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
@EzequielCaste

EzequielCaste commented Jun 28, 2020

Copy link
Copy Markdown
Contributor Author

/done

@cortizg

cortizg commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

/done

@EzequielCaste
EzequielCaste merged commit c1a59c0 into javascript-tutorial:master Jul 1, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 1, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@cortizg cortizg cortizg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EzequielCaste @javascript-translate-bot @cortizg