Visitar URL original
Microtasks by vplentinax · Pull Request #280 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Microtasks - #280

Merged
vplentinax merged 12 commits into
javascript-tutorial:masterfrom
vplentinax:microtask
Jul 9, 2020
Merged

Microtasks#280
vplentinax merged 12 commits into
javascript-tutorial:masterfrom
vplentinax:microtask

Conversation

@vplentinax

@vplentinax vplentinax commented Jun 25, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a team June 25, 2020 18:45
@iliakan iliakan mentioned this pull request Jun 25, 2020
Open
@vplentinax
vplentinax requested a review from EzequielCaste June 26, 2020 05:50
joaquinelio
joaquinelio requested changes Jul 7, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some
Anoté mi preferencia por "manejo de errores" que es ya lugar común, pero no hay nada mal en
handler = controlador.
En lo conceptual js, sin errores creo.

Comment thread 1-js/11-async/07-microtask-queue/article.md Outdated
Comment thread 1-js/11-async/07-microtask-queue/article.md Outdated
Comment thread 1-js/11-async/07-microtask-queue/article.md Outdated
Comment thread 1-js/11-async/07-microtask-queue/article.md Outdated
Comment thread 1-js/11-async/07-microtask-queue/article.md Outdated
Comment thread 1-js/11-async/07-microtask-queue/article.md Outdated
Comment thread 1-js/11-async/07-microtask-queue/article.md Outdated
Comment thread 1-js/11-async/07-microtask-queue/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 7, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinax and others added 8 commits July 7, 2020 16:39
@vplentinax @joaquinelio
Update 1-js/11-async/07-microtask-queue/article.md
ffaf1fd 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/11-async/07-microtask-queue/article.md
864bd4d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/11-async/07-microtask-queue/article.md
b636da4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/11-async/07-microtask-queue/article.md
76075aa 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/11-async/07-microtask-queue/article.md
58241d2 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/11-async/07-microtask-queue/article.md
8c5a040 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/11-async/07-microtask-queue/article.md
8a82814 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/11-async/07-microtask-queue/article.md
24cbe56 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax

vplentinax commented Jul 7, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team July 7, 2020 20:41
joaquinelio
joaquinelio requested changes Jul 8, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Uh perdón se me escapó un error! easy fixy
order acá es orden
es importante porque está hablando de la secuencia de los .then
solo eso y podes considerarlo aprobado, no me esperes

Comment thread 1-js/11-async/07-microtask-queue/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 8, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@vplentinax @joaquinelio
Update 1-js/11-async/07-microtask-queue/article.md
82b3221 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax

vplentinax commented Jul 8, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team July 8, 2020 18:28
joaquinelio
joaquinelio approved these changes Jul 9, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@vplentinax
vplentinax merged commit fcd3181 into javascript-tutorial:master Jul 9, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 9, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@EzequielCaste EzequielCaste Awaiting requested review from EzequielCaste

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vplentinax @javascript-translate-bot @joaquinelio