Visitar URL original
Hello, world by victorze · Pull Request #31 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Hello, world - #31

Merged
lizzie136 merged 4 commits into
masterfrom
unknown repository
Oct 2, 2019
Merged

Hello, world#31
lizzie136 merged 4 commits into
masterfrom
unknown repository

Conversation

@victorze

@victorze victorze commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@victorze victorze changed the title Traducción de Hello, world Hello, world Apr 18, 2019
@lizzie136
lizzie136 self-requested a review April 18, 2019 14:45
@iliakan iliakan mentioned this pull request Apr 18, 2019
Open
lizzie136
lizzie136 requested changes May 27, 2019
View reviewed changes

@lizzie136 lizzie136 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @victorze , te dejé unos comentarios. Gracias!

Comment thread 1-js/02-first-steps/01-hello-world/article.md Outdated
Comment thread 1-js/02-first-steps/01-hello-world/article.md Outdated
Comment thread 1-js/02-first-steps/01-hello-world/article.md Outdated
Comment thread 1-js/02-first-steps/01-hello-world/article.md Outdated
@CLAassistant

CLAassistant commented Jul 7, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tscandalitta
❌ victorze

victorze seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

tscandalitta
tscandalitta reviewed Sep 6, 2019
View reviewed changes

@tscandalitta tscandalitta left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizzie136 Hice varias correcciones. Lo dejo a tu disposición para que le des una revisión.

@lizzie136
lizzie136 self-requested a review October 2, 2019 15:16
@lizzie136
lizzie136 merged commit f57da03 into javascript-tutorial:master Oct 2, 2019
@lizzie136

lizzie136 commented Oct 2, 2019

Copy link
Copy Markdown
Member

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tscandalitta tscandalitta tscandalitta left review comments
@lizzie136 lizzie136 Awaiting requested review from lizzie136

Assignees

No one assigned

Labels

needs +1 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@victorze @CLAassistant @lizzie136 @tscandalitta