Visitar URL original
Promise API by joaquinelio · Pull Request #313 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Promise API - #313

Merged
joaquinelio merged 17 commits into
javascript-tutorial:masterfrom
joaquinelio:papi
Aug 6, 2020
Merged

Promise API#313
joaquinelio merged 17 commits into
javascript-tutorial:masterfrom
joaquinelio:papi

Conversation

@joaquinelio

@joaquinelio joaquinelio commented Jul 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

branch "papi"

edito:
@vplentinax , gracias por el buen humor
parece que tengo que borrar el coment porque incomoda a potenciales revisores...

@javascript-translate-bot
javascript-translate-bot requested a review from a team July 22, 2020 15:14
@iliakan iliakan mentioned this pull request Jul 22, 2020
Open
@joaquinelio
fix .race
e998eda 
primera que responda ok/err, no necesita que resuelva ok
@joaquinelio
Update article.md
e223eaf
@vplentinax
vplentinax self-requested a review August 3, 2020 02:30
vplentinax
vplentinax requested changes Aug 5, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pequeñas cositas. Se cambian y nos fuimos!.

Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Aug 5, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelio and others added 3 commits August 4, 2020 22:55
@joaquinelio @vplentinax
Update 1-js/11-async/05-promise-api/article.md
6c720ef 
Confundí resolve con fulfilled (solo successful) crei que puso "settled" para indicar ambos.  My bad.

Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@joaquinelio @vplentinax
Update 1-js/11-async/05-promise-api/article.md
d0e5b3b 
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@joaquinelio @vplentinax
Update 1-js/11-async/05-promise-api/article.md
cb8b653 
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@joaquinelio

joaquinelio commented Aug 5, 2020

Copy link
Copy Markdown
Member Author

/done

vplentinax
vplentinax approved these changes Aug 5, 2020
View reviewed changes

@vplentinax vplentinax left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo apruebo esta traducción!

maksumi
maksumi approved these changes Aug 6, 2020
View reviewed changes

@maksumi maksumi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay como dos o tres typos. Excelente traducción, solo unas pequeñas sugerencias nada serias y una pequeña llamada de atención al "exceso de comas". Merge it!

Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
Comment thread 1-js/11-async/05-promise-api/article.md Outdated
joaquinelio and others added 8 commits August 6, 2020 08:13
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
dcdbb9a 
De acuerdo, se lee mucho mejor "Veremos"

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
36ef3db 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
99d842e 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
5974d39 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
ace75fe 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
8e7e076 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
40ea7fd 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
b1f5696 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
joaquinelio and others added 3 commits August 6, 2020 08:24
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
c899ba3 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
6090923 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio Maksumi Murakami
Update 1-js/11-async/05-promise-api/article.md
5956b2c 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
joaquinelio merged commit 74278ee into javascript-tutorial:master Aug 6, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 6, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
joaquinelio deleted the papi branch August 21, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maksumi maksumi maksumi approved these changes
@vplentinax vplentinax vplentinax approved these changes
@EzequielCaste EzequielCaste Awaiting requested review from EzequielCaste

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joaquinelio @javascript-translate-bot @maksumi @vplentinax