Visitar URL original
Scrolling by Leired7 · Pull Request #330 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Scrolling - #330

Merged
joaquinelio merged 23 commits into
javascript-tutorial:masterfrom
Leired7:Scrolling
Aug 1, 2020
Merged

Scrolling#330
joaquinelio merged 23 commits into
javascript-tutorial:masterfrom
Leired7:Scrolling

Conversation

@Leired7

@Leired7 Leired7 commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

Traducido

@joaquinelio
joaquinelio self-requested a review July 31, 2020 21:50
@iliakan iliakan mentioned this pull request Jul 31, 2020
Open
joaquinelio
joaquinelio requested changes Jul 31, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Destraduje" propiedades o conceptos que debe conocer en inglés :
relativo a window, limites top-bottom,
Donde se explaya lo dejé en español, salvo donde lo remarca: bottom y se refiere al código

Comment thread 2-ui/3-event-details/8-onscroll/1-endless-page/solution.md Outdated
Comment thread 2-ui/3-event-details/8-onscroll/1-endless-page/solution.md Outdated
Comment thread 2-ui/3-event-details/8-onscroll/1-endless-page/solution.md Outdated
Comment thread 2-ui/3-event-details/8-onscroll/1-endless-page/task.md Outdated
Comment thread 2-ui/3-event-details/8-onscroll/1-endless-page/task.md Outdated
Comment thread 2-ui/3-event-details/8-onscroll/3-load-visible-img/task.md Outdated
Comment thread 2-ui/3-event-details/8-onscroll/3-load-visible-img/task.md Outdated
Comment thread 2-ui/3-event-details/8-onscroll/article.md Outdated
Comment thread 2-ui/3-event-details/8-onscroll/article.md Outdated
Comment thread 2-ui/3-event-details/8-onscroll/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 31, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Leired7 and others added 10 commits August 1, 2020 14:37
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/1-endless-page/solution.md
d5d58d1 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/1-endless-page/solution.md
efdc7ac 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/1-endless-page/solution.md
f39a7a4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/1-endless-page/task.md
78a061c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/3-load-visible-img/task.md
b08da7f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/article.md
db8261e 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/article.md
75fafd5 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/article.md
35717b6 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/3-load-visible-img/task.md
e2fc3bb 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/1-endless-page/task.md
c4c3fbe 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7

Leired7 commented Aug 1, 2020

Copy link
Copy Markdown
Contributor Author

/done

@vplentinax

vplentinax commented Aug 1, 2020

Copy link
Copy Markdown
Contributor

@Leired7 , aún quedaron cambios sin hacer. Fíjate siempre si hay datos "hidden", suelen ocultarlos para no hacer la lista muy larga. 🙈

@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/2-updown-button/task.md
c695759 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Leired7 and others added 4 commits August 1, 2020 18:44
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/3-load-visible-img/solution.md
e434070 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/3-load-visible-img/solution.md
b9f812e 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/3-load-visible-img/solution.md
d4e2538 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/3-event-details/8-onscroll/3-load-visible-img/task.md
e1c887a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7

Leired7 commented Aug 1, 2020

Copy link
Copy Markdown
Contributor Author

/done

joaquinelio
joaquinelio approved these changes Aug 1, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vplentinax
vplentinax approved these changes Aug 1, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@joaquinelio
joaquinelio merged commit 06417d2 into javascript-tutorial:master Aug 1, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 1, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@vplentinax vplentinax vplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Leired7 @javascript-translate-bot @vplentinax @joaquinelio