Visitar URL original
Class basic syntax by joaquinelio · Pull Request #341 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Class basic syntax - #341

Merged
joaquinelio merged 11 commits into
javascript-tutorial:masterfrom
joaquinelio:classbass
Aug 15, 2020
Merged

Class basic syntax#341
joaquinelio merged 11 commits into
javascript-tutorial:masterfrom
joaquinelio:classbass

Conversation

@joaquinelio

@joaquinelio joaquinelio commented Aug 10, 2020

Copy link
Copy Markdown
Member

No description provided.

@iliakan iliakan mentioned this pull request Aug 10, 2020
Open
@vplentinax
vplentinax self-requested a review August 11, 2020 02:16
EzequielCaste
EzequielCaste requested changes Aug 14, 2020
View reviewed changes

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

algunos cambios

Comment thread 1-js/09-classes/01-class/article.md Outdated
Comment thread 1-js/09-classes/01-class/article.md Outdated
Comment thread 1-js/09-classes/01-class/article.md Outdated
Comment thread 1-js/09-classes/01-class/article.md Outdated
Comment thread 1-js/09-classes/01-class/article.md Outdated
Comment thread 1-js/09-classes/01-class/article.md Outdated
Comment thread 1-js/09-classes/01-class/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Aug 14, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EzequielCaste
EzequielCaste removed the request for review from vplentinax August 14, 2020 03:05
joaquinelio and others added 7 commits August 14, 2020 07:06
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
42005d1 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
93fe7c3 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
ff890cc 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
3c6381a 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
a4247ff 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
cc30582 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
aecf331 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio

joaquinelio commented Aug 14, 2020

Copy link
Copy Markdown
Member Author

/done

@joaquinelio

joaquinelio commented Aug 14, 2020

Copy link
Copy Markdown
Member Author

Pro primera vez etuve de acuerdo en todo.

y maldita s

maksumi
maksumi approved these changes Aug 15, 2020
View reviewed changes

@maksumi maksumi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unos pequeños tipos y...
¿Ellas? ¿Quienes?
Jejeje

Comment thread 1-js/09-classes/01-class/article.md Outdated
Comment thread 1-js/09-classes/01-class/article.md Outdated
Comment thread 1-js/09-classes/01-class/article.md Outdated
Comment thread 1-js/09-classes/01-class/article.md Outdated
Comment thread 1-js/09-classes/01-class/article.md Outdated
@joaquinelio
joaquinelio merged commit 9ba6fe3 into javascript-tutorial:master Aug 15, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 15, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
joaquinelio deleted the classbass branch August 15, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maksumi maksumi maksumi approved these changes
@EzequielCaste EzequielCaste EzequielCaste approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joaquinelio @javascript-translate-bot @maksumi @EzequielCaste