Visitar URL original
Greedy and lazy quantifiers by cortizg · Pull Request #355 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Greedy and lazy quantifiers - #355

Merged
joaquinelio merged 10 commits into
javascript-tutorial:masterfrom
cortizg:es.javascript.info.9-10-glq
Aug 30, 2020
Merged

Greedy and lazy quantifiers#355
joaquinelio merged 10 commits into
javascript-tutorial:masterfrom
cortizg:es.javascript.info.9-10-glq

Conversation

@cortizg

@cortizg cortizg commented Aug 22, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@iliakan iliakan mentioned this pull request Aug 22, 2020
Open
@joaquinelio
joaquinelio self-requested a review August 23, 2020 00:31
joaquinelio
joaquinelio requested changes Aug 23, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contento que hayas traducido esto.

En viejos tiempos awkeé, grepeé y egrepeé un monton pero ya no entiendo nada.
fue arduo

Comment thread 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-tags-greedy-lazy/solution.md Outdated
Comment thread 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-tags-greedy-lazy/solution.md Outdated
Comment thread 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-tags-greedy-lazy/task.md Outdated
Comment thread 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-tags-greedy-lazy/task.md Outdated
Comment thread 9-regular-expressions/10-regexp-greedy-and-lazy/article.md Outdated
Comment thread 9-regular-expressions/10-regexp-greedy-and-lazy/article.md Outdated
Comment thread 9-regular-expressions/10-regexp-greedy-and-lazy/article.md Outdated
Comment thread 9-regular-expressions/10-regexp-greedy-and-lazy/article.md Outdated
Comment thread 9-regular-expressions/10-regexp-greedy-and-lazy/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Aug 23, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

cortizg and others added 9 commits August 23, 2020 11:51
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
b93e3da 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
4f36e0c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-ta…
e1987f3 
…gs-greedy-lazy/solution.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-ta…
4b80bdc 
…gs-greedy-lazy/solution.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-ta…
a077326 
…gs-greedy-lazy/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-ta…
920e596 
…gs-greedy-lazy/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
f4883c3 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
4b5b44d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
fb7a0c4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg

cortizg commented Aug 23, 2020

Copy link
Copy Markdown
Contributor Author

/done

joaquinelio
joaquinelio approved these changes Aug 23, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprobado
...con una sugerencia extra linea 147

Comment thread 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
vplentinax
vplentinax approved these changes Aug 27, 2020
View reviewed changes

@vplentinax vplentinax left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codiciosa no me gusta mucho, pero no le veo otra traducción jaja. Está todo bien!
Corregir lo último sugerido por Joa y listo.

@EzequielCaste

EzequielCaste commented Aug 30, 2020

Copy link
Copy Markdown
Contributor

Si @cortizg no aparece, alguien puede corregir lo de "codicioso" por "voraz" ??

@cortizg

cortizg commented Aug 30, 2020

Copy link
Copy Markdown
Contributor Author

Tendran problemas con el merge, pensé que habian mezclado ya, reinicié mi repo de cero.....

@cortizg

cortizg commented Aug 30, 2020

Copy link
Copy Markdown
Contributor Author

No puedo hacer el cambio, creo que es por limpiar mi repo

@joaquinelio

joaquinelio commented Aug 30, 2020

Copy link
Copy Markdown
Member

Ok...
Pero big brother todo lo recuerda...
Merge...

@joaquinelio
joaquinelio merged commit 6583bb4 into javascript-tutorial:master Aug 30, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 30, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@EzequielCaste EzequielCaste EzequielCaste left review comments
@vplentinax vplentinax vplentinax approved these changes

Assignees

No one assigned

Labels

changes requested needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cortizg @javascript-translate-bot @EzequielCaste @joaquinelio @vplentinax