Sandbox::https://github.com/javascript-tutorial/es.javascript.info/pull/363

homero304 · 2020-08-30T06:04:17Z

Hi
Could you review my PR?
Thanks

joaquinelio

Ta'güeno.
Un paso más a la meta.

javascript-translate-bot · 2020-08-30T09:44:14Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

…304/es.javascript.info into Dispatching-custom-events

homero304 · 2020-08-30T19:07:26Z

/done

joaquinelio

👍

Nota:
No presto atención a "click" porque ya está extendido,
pero así como no escribiimos "WOF!" cuando ladra un perro, "CLIC" es la onomatopeya correcta en español, no hacia falta que los volvieras al inglés.

EzequielCaste

Bastante bien 👍 💯

Hice algunas sugerencias, nada grave. Se lee bien y fluido.

Gracias!!

javascript-translate-bot · 2020-08-31T14:48:29Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>

homero304 · 2020-08-31T18:47:12Z

/done

…vascript.info into Dispatching-custom-events

javascript-translate-bot · 2020-08-31T18:57:34Z

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Dispatching custom events

e742eff

javascript-translate-bot added the review needed label Aug 30, 2020

joaquinelio self-requested a review August 30, 2020 07:47

joaquinelio requested changes Aug 30, 2020

View reviewed changes

javascript-translate-bot removed the review needed label Aug 30, 2020

javascript-translate-bot added the changes requested label Aug 30, 2020

omero329 and others added 8 commits August 30, 2020 13:54

Update 2-ui/2-events/05-dispatch-events/article.md

4ecec80

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/05-dispatch-events/article.md

d84feae

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/05-dispatch-events/article.md

fa758b0

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/05-dispatch-events/article.md

bd99887

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

changed to "event.isTrusted es true" instead

ab5ed13

Update 2-ui/2-events/05-dispatch-events/article.md

e116d39

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/2-events/05-dispatch-events/article.md

b80822d

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Merge branch 'Dispatching-custom-events' of https://github.com/homero…

929bbe6

…304/es.javascript.info into Dispatching-custom-events

javascript-translate-bot added review needed and removed changes requested labels Aug 30, 2020

homero304 commented Aug 30, 2020

View reviewed changes

Comment thread 2-ui/2-events/05-dispatch-events/article.md Outdated

Comment thread 2-ui/2-events/05-dispatch-events/article.md Outdated

omero329 added 2 commits August 30, 2020 14:25

removed extra space between dispatchEvent and (event)

56902ed

changed "click" to click

8cff381

joaquinelio approved these changes Aug 30, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels Aug 30, 2020

EzequielCaste requested changes Aug 31, 2020

View reviewed changes

javascript-translate-bot added the changes requested label Aug 31, 2020

omero329 and others added 3 commits August 31, 2020 13:42

Update 2-ui/2-events/05-dispatch-events/article.md

e35e2d8

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>

Update 2-ui/2-events/05-dispatch-events/article.md

2116faf

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>

Update 2-ui/2-events/05-dispatch-events/article.md

7057a5a

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>

omero329 and others added 2 commits August 31, 2020 13:43

Update 2-ui/2-events/05-dispatch-events/article.md

5399dde

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>

Update 2-ui/2-events/05-dispatch-events/article.md

b9dfd9d

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>

javascript-translate-bot added review needed and removed changes requested labels Aug 31, 2020

Merge branch 'master' of https://github.com/javascript-tutorial/es.ja…

a882538

…vascript.info into Dispatching-custom-events

EzequielCaste approved these changes Aug 31, 2020

View reviewed changes

EzequielCaste merged commit f15313a into javascript-tutorial:master Aug 31, 2020

iliakan mentioned this pull request Aug 31, 2020

Spanish Translation Progress #17

Open

Conversation

homero304 commented Aug 30, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 30, 2020

Uh oh!

homero304 commented Aug 30, 2020

Uh oh!

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

EzequielCaste left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 31, 2020

Uh oh!

homero304 commented Aug 31, 2020

Uh oh!

javascript-translate-bot commented Aug 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants