Visitar URL original
Selection and Range by vplentinax · Pull Request #382 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Selection and Range - #382

Merged
vplentinax merged 6 commits into
javascript-tutorial:masterfrom
vplentinax:range
Sep 22, 2020
Merged

Selection and Range#382
vplentinax merged 6 commits into
javascript-tutorial:masterfrom
vplentinax:range

Conversation

@vplentinax

@vplentinax vplentinax commented Sep 20, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a team September 20, 2020 20:42
@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 20, 2020
Open
joaquinelio
joaquinelio requested changes Sep 21, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tu criterio, una vez consideres las suggest -una con multiple choice =)
asuman mi aprobacion no hace falta que me esperen

Comment thread 2-ui/99-ui-misc/02-selection-range/article.md Outdated
Comment thread 2-ui/99-ui-misc/02-selection-range/article.md Outdated
Comment thread 2-ui/99-ui-misc/02-selection-range/article.md Outdated
Comment thread 2-ui/99-ui-misc/02-selection-range/article.md Outdated
Comment thread 2-ui/99-ui-misc/02-selection-range/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 21, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinax and others added 5 commits September 21, 2020 16:03
@vplentinax @joaquinelio
Update 2-ui/99-ui-misc/02-selection-range/article.md
cc37aba 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/99-ui-misc/02-selection-range/article.md
0d00d67 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/99-ui-misc/02-selection-range/article.md
7269b4e 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/99-ui-misc/02-selection-range/article.md
5dadc78 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/99-ui-misc/02-selection-range/article.md
cf558ff 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax

vplentinax commented Sep 21, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team September 21, 2020 20:05
joaquinelio
joaquinelio approved these changes Sep 21, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, la fácil, aceptar todo.
Bue, yo tambien, apruebo sin releer.

@vplentinax
vplentinax merged commit 4885a21 into javascript-tutorial:master Sep 22, 2020
@javascript-translate-bot

javascript-translate-bot commented Sep 22, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vplentinax @javascript-translate-bot @joaquinelio