Visitar URL original
JavaScript animations by homero304 · Pull Request #389 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

JavaScript animations - #389

Merged
joaquinelio merged 8 commits into
javascript-tutorial:masterfrom
homero304:JavaScript-animations
Oct 2, 2020
Merged

JavaScript animations#389
joaquinelio merged 8 commits into
javascript-tutorial:masterfrom
homero304:JavaScript-animations

Conversation

@homero304

@homero304 homero304 commented Sep 27, 2020

Copy link
Copy Markdown
Contributor

please review my PR

@javascript-translate-bot
javascript-translate-bot requested a review from a team September 27, 2020 22:45
@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 27, 2020
Open
joaquinelio
joaquinelio approved these changes Sep 28, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta perfecto
nimiedades si queres cambiar puse suggest,
cambies o no ok para online

Comment thread 7-animation/3-js-animation/article.md Outdated
Comment thread 7-animation/3-js-animation/article.md Outdated
Comment thread 7-animation/3-js-animation/article.md Outdated
Comment thread 7-animation/3-js-animation/article.md
- `draw` -- la función para dibujar la animación.

Surely we could improve it, add more bells and whistles, but JavaScript animations are not applied on a daily basis. They are used to do something interesting and non-standard. So you'd want to add the features that you need when you need them.
Seguramente podríamos mejorarlo, agregar más campanas y silbidos, pero las animaciones de JavaScript no se aplican a diario. Se utilizan para hacer algo interesante y no estándar. Por lo tanto, querrás agregar las funciones que necesitas cuando las necesites.

@joaquinelio joaquinelio Sep 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

estaria bien...
pero es expresion muy usada que se pierde traducida
agregar mas...
...fanfarria, barroco , trompetas y bombos...
no tengo sugerencia sorry :-P
y menos que no sea regional

@homero304 homero304 Sep 28, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no se que ponerle tampoco X.X creo que la dejare asi..

Comment thread 7-animation/3-js-animation/article.md Outdated
vplentinax
vplentinax approved these changes Oct 1, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki

@joaquinelio
joaquinelio merged commit 095fb6f into javascript-tutorial:master Oct 2, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 2, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio

joaquinelio commented Oct 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@homero304
ah...
es algo que añadimos, silvidos es dificil de añadir
agregarle "pitos/silbatos y campanas" al programa era mas razonable, jaja
tarde
pero NO importa
no voy a hacer un pr para eso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@vplentinax vplentinax vplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@homero304 @javascript-translate-bot @joaquinelio @vplentinax @omero329