Visitar URL original
WebSocket by joaquinelio · Pull Request #447 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

WebSocket - #447

Merged
joaquinelio merged 8 commits into
javascript-tutorial:masterfrom
joaquinelio:wueso
Nov 20, 2020
Merged

WebSocket#447
joaquinelio merged 8 commits into
javascript-tutorial:masterfrom
joaquinelio:wueso

Conversation

@joaquinelio

@joaquinelio joaquinelio commented Nov 18, 2020

Copy link
Copy Markdown
Member

wue so

los ejemplos archivos html y js tienen un par de coments... pereza...

repiten el codigo del articulo, que si esta traducido

@javascript-translate-bot
javascript-translate-bot requested a review from a team November 18, 2020 06:17
@javascript-translate-bot javascript-translate-bot mentioned this pull request Nov 18, 2020
Open
vplentinax
vplentinax approved these changes Nov 20, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cositas pequeñas, por mí, se puede hacer merge una vez aceptadas

Comment thread 5-network/11-websocket/article.md Outdated
Comment thread 5-network/11-websocket/article.md Outdated
Comment thread 5-network/11-websocket/article.md Outdated
Comment thread 5-network/11-websocket/article.md Outdated
Comment thread 5-network/11-websocket/article.md Outdated
joaquinelio and others added 2 commits November 20, 2020 18:44
@joaquinelio @vplentinax
Apply suggestions from code review
4c4ab50 
Co-authored-by: ᐯᑭᒪEᑎTIᑎᗩ᙭ ᐯᑭ <34555644+vplentinax@users.noreply.github.com>
@joaquinelio
descripto descrito
afabef8
@joaquinelio
joaquinelio merged commit fa5f4ec into javascript-tutorial:master Nov 20, 2020
@javascript-translate-bot

javascript-translate-bot commented Nov 20, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
joaquinelio deleted the wueso branch November 20, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplentinax vplentinax vplentinax approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquinelio @javascript-translate-bot @vplentinax