Visitar URL original
Conditional operators: if, '?' by Giorgiosaud · Pull Request #95 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Conditional operators: if, '?' - #95

Closed
Giorgiosaud wants to merge 11 commits into
javascript-tutorial:masterfrom
Giorgiosaud:master
Closed

Conditional operators: if, '?'#95
Giorgiosaud wants to merge 11 commits into
javascript-tutorial:masterfrom
Giorgiosaud:master

Conversation

@Giorgiosaud

@Giorgiosaud Giorgiosaud commented Sep 8, 2019

Copy link
Copy Markdown
Contributor

Conditional operators: if, '?'

@javascript-translate-bot
javascript-translate-bot requested a review from a team September 8, 2019 00:26
@CLAassistant

CLAassistant commented Sep 8, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@iliakan iliakan mentioned this pull request Sep 8, 2019
Open
tscandalitta
tscandalitta reviewed Sep 8, 2019
View reviewed changes
Comment thread 1-js/02-first-steps/10-ifelse/1-if-zero-string/solution.md Outdated
tscandalitta
tscandalitta reviewed Sep 8, 2019
View reviewed changes
Comment thread 1-js/02-first-steps/10-ifelse/1-if-zero-string/task.md Outdated
@Giorgiosaud
Giorgiosaud requested review from tscandalitta and removed request for a team September 8, 2019 03:20
lizzie136
lizzie136 requested changes Sep 10, 2019
View reviewed changes

@lizzie136 lizzie136 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aún no he terminado este review, pero te dejo los comentarios que ya tengo contemplados. Gracias @Giorgiosaud!!

Comment thread 1-js/02-first-steps/10-ifelse/2-check-standard/task.md Outdated
Comment thread 1-js/02-first-steps/10-ifelse/5-rewrite-if-question/task.md Outdated
Comment thread 1-js/02-first-steps/10-ifelse/6-rewrite-if-else-question/task.md Outdated
Comment thread 1-js/02-first-steps/10-ifelse/article.md Outdated
# Operadores condicionales: if, '?'

Sometimes, we need to perform different actions based on different conditions.
Algunas Veces, necesitamos ejecutar diferentes acciones basadas en diferentes condiciones.

@lizzie136 lizzie136 Sep 10, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algunas veces

Comment thread 1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread 1-js/02-first-steps/10-ifelse/article.md Outdated
## Conversion Booleana

The `if (…)` statement evaluates the expression in its parentheses and converts the result to a boolean.
La sentencia `if (…)` evalua la exprecion dentro de sus parentesis y convierte el resultado en booleano.

@lizzie136 lizzie136 Sep 10, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expresión, y paréntesis

Comment thread 1-js/02-first-steps/10-ifelse/article.md Outdated
Comment thread 1-js/02-first-steps/10-ifelse/article.md Outdated
## La clausula "else"

The `if` statement may contain an optional "else" block. It executes when the condition is false.
La sentencia `if` quizás contenga un bloque "de lo contrario" opcional. Este se ejecutará cuando la condición sea falsa.

@lizzie136 lizzie136 Sep 10, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creo que en este caso "else" no debería ir traducido, o al menos si vas a poner la traducción podría ir como que se traduce o lee como "de lo contrario"

Comment thread 1-js/02-first-steps/10-ifelse/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 10, 2019

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Giorgiosaud

Giorgiosaud commented Sep 11, 2019

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team September 11, 2019 00:21
@Giorgiosaud
Giorgiosaud requested review from lizzie136 and removed request for a team September 11, 2019 00:21
lizzie136
lizzie136 approved these changes Oct 4, 2019
View reviewed changes

@lizzie136 lizzie136 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias, en adelante, hay lugares donde dice parametros sin tilde, que debería ser parámetros.

@vplentinax vplentinax mentioned this pull request Jun 5, 2020
Merged
@vplentinax vplentinax closed this Jun 5, 2020
@vplentinax vplentinax reopened this Jun 5, 2020
@vplentinax vplentinax mentioned this pull request Jun 5, 2020
Merged
@vplentinax vplentinax closed this Jun 5, 2020
@Giorgiosaud
Giorgiosaud deleted the master branch October 30, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lizzie136 lizzie136 lizzie136 approved these changes
@tscandalitta tscandalitta Awaiting requested review from tscandalitta

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Giorgiosaud @CLAassistant @javascript-translate-bot @lizzie136 @tscandalitta @vplentinax