Visitar URL original
Garbage collection by mahdiHash · Pull Request #123 · javascript-tutorial/fa.javascript.info · GitHub
Skip to content

Garbage collection - #123

Merged
mahdyar merged 12 commits into
javascript-tutorial:masterfrom
mahdiHash:master
May 16, 2021
Merged

Garbage collection#123
mahdyar merged 12 commits into
javascript-tutorial:masterfrom
mahdiHash:master

Conversation

@mahdiHash

@mahdiHash mahdiHash commented May 16, 2021

Copy link
Copy Markdown
Contributor

Please review and comment / commit if anything is wrong.

@javascript-translate-bot
javascript-translate-bot requested a review from a team May 16, 2021 14:41
@javascript-translate-bot javascript-translate-bot mentioned this pull request May 16, 2021
Open
mahdyar
mahdyar requested changes May 16, 2021
View reviewed changes
Comment thread 1-js/04-object-basics/03-garbage-collection/article.md Outdated
Comment thread 1-js/04-object-basics/03-garbage-collection/article.md Outdated
Comment thread 1-js/04-object-basics/03-garbage-collection/article.md Outdated
Comment thread 1-js/04-object-basics/03-garbage-collection/article.md Outdated
Comment thread 1-js/04-object-basics/03-garbage-collection/article.md Outdated
Comment thread 1-js/04-object-basics/03-garbage-collection/article.md Outdated
Comment thread 1-js/04-object-basics/03-garbage-collection/article.md Outdated
Comment thread 1-js/04-object-basics/03-garbage-collection/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented May 16, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

mahdiHash and others added 2 commits May 16, 2021 21:12
@mahdiHash @mahdyar
Apply suggestions from code review
4459f0e 
Co-authored-by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash
Apply suggested change
f7478c3
@mahdiHash

mahdiHash commented May 16, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for your review, @mahdyar
/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team May 16, 2021 16:45
mahdyar
mahdyar approved these changes May 16, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

@mahdyar
mahdyar merged commit ab4b86c into javascript-tutorial:master May 16, 2021
@javascript-translate-bot

javascript-translate-bot commented May 16, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

mahdyar added a commit that referenced this pull request May 16, 2021
@mahdyar
Merge pull request #124 from mahdiHashemi14/master
6ec8008 
Fix "Garbage collection" (#123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar