Visitar URL original
The old "var" by mahdiHash · Pull Request #161 · javascript-tutorial/fa.javascript.info · GitHub
Skip to content

The old "var" - #161

Merged
mahdyar merged 9 commits into
javascript-tutorial:masterfrom
mahdiHash:master
Oct 10, 2021
Merged

The old "var"#161
mahdyar merged 9 commits into
javascript-tutorial:masterfrom
mahdiHash:master

Conversation

@mahdiHash

@mahdiHash mahdiHash commented Oct 9, 2021

Copy link
Copy Markdown
Contributor

Last line needs more attention
Please review and comment/commit if anything is wrong

@mahdiHash
Replace whole article with English version
1d59c6c 
Some lines were duplicate and I found out that the article has "old/new parts", and since it's not translated I decided to just replace it.
@mahdiHash
Translate a part of article
f36050a
@mahdiHash
Translate a part of article
38ff899
@mahdiHash
Translate a part of article
dd64bde
@mahdiHash
Change a word for better understanding
a6bbd2a
@mahdiHash
Translate a part of article
d07c051
@mahdiHash
Translate article
4682926 
Last line needs a more attention
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 9, 2021 09:49
@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 9, 2021
Open
mahdyar
mahdyar requested changes Oct 9, 2021
View reviewed changes
Comment thread 1-js/06-advanced-functions/04-var/article.md Outdated
Comment thread 1-js/06-advanced-functions/04-var/article.md Outdated
Comment thread 1-js/06-advanced-functions/04-var/article.md
Comment thread 1-js/06-advanced-functions/04-var/article.md Outdated
Comment thread 1-js/06-advanced-functions/04-var/article.md Outdated
Comment thread 1-js/06-advanced-functions/04-var/article.md
Comment thread 1-js/06-advanced-functions/04-var/article.md Outdated
Comment thread 1-js/06-advanced-functions/04-var/article.md
Comment thread 1-js/06-advanced-functions/04-var/article.md
@javascript-translate-bot

javascript-translate-bot commented Oct 9, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

mahdiHash and others added 2 commits October 9, 2021 19:11
@mahdiHash @mahdyar
Apply suggestions from code review
8419d8c 
Co-authored-by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash
Fix a typo and change a word
1710d2b
@mahdiHash

mahdiHash commented Oct 9, 2021

Copy link
Copy Markdown
Contributor Author

Thank you @mahdyar
/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team October 9, 2021 15:44
mahdyar
mahdyar approved these changes Oct 10, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

@mahdyar
mahdyar merged commit 536b510 into javascript-tutorial:master Oct 10, 2021
@javascript-translate-bot

javascript-translate-bot commented Oct 10, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar