Visitar URL original
Private and protected properties and methods by mahdiHash · Pull Request #182 · javascript-tutorial/fa.javascript.info · GitHub
Skip to content

Private and protected properties and methods - #182

Merged
mahdyar merged 9 commits into
javascript-tutorial:masterfrom
mahdiHash:master
Dec 24, 2021
Merged

Private and protected properties and methods#182
mahdyar merged 9 commits into
javascript-tutorial:masterfrom
mahdiHash:master

Conversation

@mahdiHash

@mahdiHash mahdiHash commented Dec 20, 2021

Copy link
Copy Markdown
Contributor

Please review and comment/commit if anything is wrong

@javascript-translate-bot
javascript-translate-bot requested a review from a team December 20, 2021 09:31
@javascript-translate-bot javascript-translate-bot mentioned this pull request Dec 20, 2021
Open
mahdiHash
mahdiHash commented Dec 20, 2021
View reviewed changes
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
mahdiHash
mahdiHash commented Dec 20, 2021
View reviewed changes
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
mahdiHash
mahdiHash commented Dec 20, 2021
View reviewed changes
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md
mahdiHash
mahdiHash commented Dec 20, 2021
View reviewed changes
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
mahdiHash
mahdiHash commented Dec 20, 2021
View reviewed changes
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md
mahdiHash
mahdiHash commented Dec 20, 2021
View reviewed changes
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
@mahdiHash
mahdiHash marked this pull request as ready for review December 20, 2021 09:35
mahdyar
mahdyar requested changes Dec 23, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the requested changes.

@javascript-translate-bot

javascript-translate-bot commented Dec 23, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash @mahdyar
Apply suggestions from code review
1dcd92e 
Co-authored-by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash

mahdiHash commented Dec 23, 2021

Copy link
Copy Markdown
Contributor Author

Thank you @mahdyar
/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team December 23, 2021 16:19
mahdyar
mahdyar approved these changes Dec 24, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHash!

@mahdyar
mahdyar merged commit 4964d5d into javascript-tutorial:master Dec 24, 2021
@javascript-translate-bot

javascript-translate-bot commented Dec 24, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar