Visitar URL original

Mixins by mahdiHash · Pull Request #189 · javascript-tutorial/fa.javascript.info · GitHub

Repository navigation

Mixins - #189

Merged

mahdyar merged 10 commits into

javascript-tutorial:masterfrom

mahdiHash:master

Jan 10, 2022

mahdiHash commented Jan 8, 2022

Contributor

Please review and comment/commit if anything is wrong.

mahdiHash added 7 commits

January 6, 2022 14:40


          Translate a part of article

fcefb3a

Line 7 needs more attention


          Translate a part of article

165c8cb

Line 19 needs more attention.


          Translate a part of article

68ed640

Line 115, 127 and 139 need more attention.


          Translate a part of article

89171eb

Line 168 needs more attention.


          Translate article

3ab3926

Line 206 needs more attention.


          Translate comments of "head.html"

be0c46a


          Merge branch 'javascript-tutorial:master' into master

172f3e3

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

January 8, 2022 13:31

javascript-translate-bot mentioned this pull request

Persian (Farsi) Translation Progress #1

Open

mahdiHash commented

View reviewed changes

1-js/09-classes/07-mixins/article.md

mahdiHash commented

View reviewed changes

1-js/09-classes/07-mixins/article.md Outdated

mahdiHash commented

View reviewed changes

1-js/09-classes/07-mixins/article.md

mahdiHash commented

View reviewed changes

1-js/09-classes/07-mixins/article.md Outdated

mahdiHash commented

View reviewed changes

1-js/09-classes/07-mixins/article.md Outdated

mahdiHash commented

View reviewed changes

1-js/09-classes/07-mixins/article.md

mahdiHash commented

View reviewed changes

1-js/09-classes/07-mixins/article.md

mahdiHash marked this pull request as ready for review

January 8, 2022 13:36

mahdyar approved these changes

View reviewed changes

mahdyar left a comment

Member

Please review the suggested change(s) and request for another review.

javascript-translate-bot added needs +1 and removed review needed labels

mahdyar requested changes

View reviewed changes

mahdyar left a comment

Member

Please review the suggested change(s) and request for another review.

javascript-translate-bot added the changes requested label

javascript-translate-bot commented Jan 9, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻


          Apply suggestions from code review

c4e040e

Co-authored by: Mahdyar Hasanpour <thisismahdyar@gmail.com>

Beroozam reviewed

View reviewed changes

1-js/09-classes/07-mixins/article.md Outdated

mahdiHash added 2 commits

January 10, 2022 12:50


          Change a line

89b3ec1

Co-authored by: Mahdyar Hasanpour <thisismahdyar@gmail.com>


          Change a line

f3b1569

Co-authored by: @Beroozam

mahdiHash commented Jan 10, 2022 •

edited

Loading

Contributor Author

Thanks for your reviews @mahdyar @Beroozam
/done

javascript-translate-bot removed the changes requested label

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

January 10, 2022 09:28

mahdyar approved these changes

View reviewed changes

mahdyar left a comment

Member

LGTM!

mahdyar merged commit c6eeb0a into javascript-tutorial:master

javascript-translate-bot commented Jan 10, 2022

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs +1 review needed