Visitar URL original
Error handling, "try...catch" by mahdiHash · Pull Request #194 · javascript-tutorial/fa.javascript.info · GitHub
Skip to content

Error handling, "try...catch" - #194

Merged
mahdyar merged 17 commits into
javascript-tutorial:masterfrom
mahdiHash:master
Feb 6, 2022
Merged

Error handling, "try...catch"#194
mahdyar merged 17 commits into
javascript-tutorial:masterfrom
mahdiHash:master

Conversation

@mahdiHash

@mahdiHash mahdiHash commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Please review and comment/commit if anything is wrong.

@mahdiHash
Translate a part of article
99393df
@mahdiHash
Translate a part of article
c409c1f 
Line 88 needs more attention
@mahdiHash
Translate a part of article
90b66cc
@mahdiHash
Translate a part of article
235295e 
Line 164 needs more attention.
@mahdiHash
Translate a part of article
c6b2757
@mahdiHash
Translate a part of article
7216047
@mahdiHash
Translate a part of article
1b5e84d 
Line 286 needs more attention.
@mahdiHash
Translate a part of article
b890723 
Line 354 needs more attention.
@mahdiHash
Translate a part of article
81c0b68 
Line 496 needs more attention.
@mahdiHash
Translate a part of article
8205bda
@mahdiHash
Change محاسبه to اندازهگیری
edb39d2
@mahdiHash
Replace a dot with a comma
c915cb5
@mahdiHash
Translate a part of article
106cec8
@mahdiHash
Translate a part of article
40dd781 
Line 667 and 626 need more attention.
@mahdiHash
Translate "finally-or-code-after" task and solution
1975b58
@mahdiHash
Change the comma
026c81f
@javascript-translate-bot
javascript-translate-bot requested a review from a team February 4, 2022 18:22
@javascript-translate-bot javascript-translate-bot mentioned this pull request Feb 4, 2022
Open
mahdiHash
mahdiHash commented Feb 4, 2022
View reviewed changes
Comment thread 1-js/10-error-handling/1-try-catch/article.md
mahdiHash
mahdiHash commented Feb 4, 2022
View reviewed changes
Comment thread 1-js/10-error-handling/1-try-catch/article.md
mahdiHash
mahdiHash commented Feb 4, 2022
View reviewed changes
Comment thread 1-js/10-error-handling/1-try-catch/article.md
mahdiHash
mahdiHash commented Feb 4, 2022
View reviewed changes
Comment thread 1-js/10-error-handling/1-try-catch/article.md Outdated
mahdiHash
mahdiHash commented Feb 4, 2022
View reviewed changes
Comment thread 1-js/10-error-handling/1-try-catch/article.md Outdated
mahdiHash
mahdiHash commented Feb 4, 2022
View reviewed changes
Comment thread 1-js/10-error-handling/1-try-catch/article.md
mahdiHash
mahdiHash commented Feb 4, 2022
View reviewed changes
Comment thread 1-js/10-error-handling/1-try-catch/article.md
@mahdiHash
mahdiHash marked this pull request as ready for review February 4, 2022 18:26
mahdyar
mahdyar requested changes Feb 5, 2022
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggested change(s) and request another review.

@javascript-translate-bot

javascript-translate-bot commented Feb 5, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash @mahdyar
Apply suggestions from code review
1449c45 
Co-authored-by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash

mahdiHash commented Feb 5, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for your review, @mahdyar.
/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team February 5, 2022 19:04
@mahdyar

mahdyar commented Feb 6, 2022

Copy link
Copy Markdown
Member

Thank you, @mahdiHash!

@mahdyar
mahdyar merged commit fd8848b into javascript-tutorial:master Feb 6, 2022
@javascript-translate-bot

javascript-translate-bot commented Feb 6, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes
+1 more reviewer
@Beroozam Beroozam Beroozam left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mahdiHash @javascript-translate-bot @mahdyar @Beroozam