Visitar URL original
Promises chaining by mahdiHash · Pull Request #223 · javascript-tutorial/fa.javascript.info · GitHub
Skip to content

Promises chaining - #223

Merged
mahdyar merged 8 commits into
javascript-tutorial:masterfrom
mahdiHash:master
Sep 3, 2022
Merged

Promises chaining#223
mahdyar merged 8 commits into
javascript-tutorial:masterfrom
mahdiHash:master

Conversation

@mahdiHash

@mahdiHash mahdiHash commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

Please review and comment/commit if anything is wrong.

@javascript-translate-bot
javascript-translate-bot requested a review from a team September 1, 2022 18:26
@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 1, 2022
Open
mahdiHash
mahdiHash commented Sep 1, 2022
View reviewed changes
Comment thread 1-js/11-async/03-promise-chaining/article.md
mahdiHash
mahdiHash commented Sep 1, 2022
View reviewed changes
Comment thread 1-js/11-async/03-promise-chaining/article.md
mahdiHash
mahdiHash commented Sep 1, 2022
View reviewed changes
Comment thread 1-js/11-async/03-promise-chaining/article.md
@mahdiHash
mahdiHash marked this pull request as ready for review September 1, 2022 18:27
mahdyar
mahdyar requested changes Sep 2, 2022
View reviewed changes
Comment thread 1-js/11-async/03-promise-chaining/article.md Outdated
Comment thread 1-js/11-async/03-promise-chaining/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Sep 2, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash

mahdiHash commented Sep 3, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for your review, @mahdyar.
/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team September 3, 2022 16:26
mahdyar
mahdyar approved these changes Sep 3, 2022
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHash!

@mahdyar
mahdyar merged commit 1d3bef6 into javascript-tutorial:master Sep 3, 2022
@javascript-translate-bot

javascript-translate-bot commented Sep 3, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar