Visitar URL original
Update 'Type' section · Pull Request #245 · javascript-tutorial/fa.javascript.info · GitHub
Skip to content

Update 'Type' section - #245

Merged
mahdiHash merged 6 commits into
masterfrom
unknown repository
Dec 8, 2022
Merged

Update 'Type' section#245
mahdiHash merged 6 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Dec 4, 2022

Copy link
Copy Markdown

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a team December 4, 2022 17:45
@CLAassistant

CLAassistant commented Dec 4, 2022

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

mahdiHash
mahdiHash reviewed Dec 6, 2022
View reviewed changes

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
Ignore the changes for "primitive" translation for now.

Comment thread 1-js/02-first-steps/05-types/article.md Outdated
Comment thread 1-js/02-first-steps/05-types/article.md Outdated
Comment thread 1-js/02-first-steps/05-types/article.md Outdated
Comment thread 1-js/02-first-steps/05-types/article.md Outdated
Bexacuter and others added 4 commits December 7, 2022 13:19
Bexacuter @mahdiHash
Update 1-js/02-first-steps/05-types/article.md
a9b27ff 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
Bexacuter @mahdiHash
Update 1-js/02-first-steps/05-types/article.md
0f76f3d 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
Bexacuter @mahdiHash
Update 1-js/02-first-steps/05-types/article.md
c9dd745 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
Bexacuter
Update 'Type' section - apply suggestion
39732f0
mahdiHash
mahdiHash reviewed Dec 7, 2022
View reviewed changes
Comment thread 1-js/02-first-steps/05-types/1-string-quotes/solution.md Outdated
@mahdiHash

mahdiHash commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @Bexacuter.

@mahdiHash
mahdiHash merged commit 00869ef into javascript-tutorial:master Dec 8, 2022
@mahdiHash mahdiHash mentioned this pull request Dec 14, 2022
Open
18 of 87 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CLAassistant @mahdiHash @mahdyar @javascript-translate-bot