Visitar URL original
Fetch by amirroox · Pull Request #264 · javascript-tutorial/fa.javascript.info · GitHub
Skip to content

Fetch - #264

Merged
mahdyar merged 3 commits into
javascript-tutorial:masterfrom
amirroox:master
Jul 12, 2023
Merged

Fetch#264
mahdyar merged 3 commits into
javascript-tutorial:masterfrom
amirroox:master

Conversation

@amirroox

@amirroox amirroox commented Jul 8, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a team July 8, 2023 16:21
@CLAassistant

CLAassistant commented Jul 8, 2023 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Jul 8, 2023
Open
@mahdiHash mahdiHash self-assigned this Jul 10, 2023
mahdiHash
mahdiHash suggested changes Jul 11, 2023
View reviewed changes

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions (pay attention to the ones that are needed to be applied to the whole article).
You can add the suggestions to a batch and create a commit just once (docs).

Comment thread 5-network/01-fetch/article.md Outdated
Comment thread 5-network/01-fetch/article.md Outdated
Comment thread 5-network/01-fetch/article.md Outdated
Comment thread 5-network/01-fetch/article.md Outdated
Comment thread 5-network/01-fetch/article.md Outdated
Comment thread 5-network/01-fetch/article.md Outdated
Comment thread 5-network/01-fetch/article.md Outdated
Comment thread 5-network/01-fetch/article.md Outdated
Comment thread 5-network/01-fetch/01-fetch-users/solution.md Outdated
Comment thread 5-network/01-fetch/01-fetch-users/solution.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 11, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@amirroox

amirroox commented Jul 12, 2023

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team July 12, 2023 19:24
mahdyar
mahdyar approved these changes Jul 12, 2023
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mahdyar
mahdyar merged commit e7279d0 into javascript-tutorial:master Jul 12, 2023
@javascript-translate-bot

javascript-translate-bot commented Jul 12, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes
+1 more reviewer
@mahdiHash mahdiHash mahdiHash requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mahdiHash mahdiHash

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amirroox @CLAassistant @javascript-translate-bot @mahdyar @mahdiHash