Visitar URL original
Generators by alivarastepour · Pull Request #270 · javascript-tutorial/fa.javascript.info · GitHub
Skip to content

Generators - #270

Merged
mahdyar merged 11 commits into
javascript-tutorial:masterfrom
alivarastepour:master
Jul 15, 2023
Merged

Generators#270
mahdyar merged 11 commits into
javascript-tutorial:masterfrom
alivarastepour:master

Conversation

@alivarastepour

@alivarastepour alivarastepour commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

translation of article, task and solution is added.

@alivarastepour
translation of generators is added(partial)
7094bb2
@alivarastepour
Update article.md
88ed6d8 
translation of `generators` is completed
@alivarastepour
Update task.md
398a8a5 
added task description for `generators`
@alivarastepour
Update solution.md
f0567b6 
added solution translation for `generators`
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 13, 2023 11:33
@CLAassistant

CLAassistant commented Jul 13, 2023 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Jul 13, 2023
Open
@mahdiHash

mahdiHash commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

سلام وقت بخیر.
بابت مشارکت و کمک شما ممنونم.
لطفا همه خط‌هایی که اضافه کردین رو حذف کنین.
تعداد خط‌های تمام فایل‌ها باید با تعداد خط‌ها قبل از ترجمه یکی باشه.
هر وقت انجام دادین لطفا /done رو کامنت کنین.

@alivarastepour

alivarastepour commented Jul 14, 2023

Copy link
Copy Markdown
Contributor Author

/done

mahdiHash
mahdiHash suggested changes Jul 15, 2023
View reviewed changes

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
Change the translation of "object" to «شیء» anywhere else needed.
You can add the suggestions to a batch and create a commit just once (docs).

Comment thread 1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md Outdated
Comment thread 1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md Outdated
Comment thread 1-js/12-generators-iterators/1-generators/article.md Outdated
Comment thread 1-js/12-generators-iterators/1-generators/article.md Outdated
Comment thread 1-js/12-generators-iterators/1-generators/article.md Outdated
Comment thread 1-js/12-generators-iterators/1-generators/article.md Outdated
Comment thread 1-js/12-generators-iterators/1-generators/article.md Outdated
Comment thread 1-js/12-generators-iterators/1-generators/article.md Outdated
Comment thread 1-js/12-generators-iterators/1-generators/article.md Outdated
Comment thread 1-js/12-generators-iterators/1-generators/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 15, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

alivarastepour and others added 3 commits July 15, 2023 11:21
@alivarastepour

alivarastepour commented Jul 15, 2023

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team July 15, 2023 07:59
@mahdiHash

mahdiHash commented Jul 15, 2023

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @alivarastepour :D

@mahdyar
mahdyar merged commit 3259f1a into javascript-tutorial:master Jul 15, 2023
@javascript-translate-bot

javascript-translate-bot commented Jul 15, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes
+1 more reviewer
@mahdiHash mahdiHash mahdiHash approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alivarastepour @CLAassistant @mahdiHash @javascript-translate-bot @mahdyar