Visitar URL original
Translate UI — Events / Peristiwa by EmptyWork · Pull Request #234 · javascript-tutorial/id.javascript.info · GitHub
Skip to content

Translate UI — Events / Peristiwa - #234

Merged
yoga1234 merged 17 commits into
javascript-tutorial:masterfrom
EmptyWork:master
Nov 29, 2021
Merged

Translate UI — Events / Peristiwa#234
yoga1234 merged 17 commits into
javascript-tutorial:masterfrom
EmptyWork:master

Conversation

@EmptyWork

@EmptyWork EmptyWork commented Nov 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proses Penerjemahan

Status : masih menerjemahkan.

Translate events dan semua keturunannya

Tree file yang sedang di terjemahkan

2-ui
├───2-events
│   ├───index.md ✅
│   ├───01-introduction-browser-events
│   │   ├───article.md [===50%  ]
│   │   ├───01-hide-other ✅
│   │   ├───02-hide-self-onclick ✅
│   │   ├───03-which-handlers-run ✅
│   │   ├───04-move-ball-field [3/4]
│   │   │   ├───solution.md

@javascript-translate-bot
javascript-translate-bot requested a review from a team November 27, 2021 02:18
@CLAassistant

CLAassistant commented Nov 27, 2021 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@EmptyWork
EmptyWork marked this pull request as draft November 27, 2021 02:19
EmptyWork
EmptyWork commented Nov 27, 2021
View reviewed changes

@EmptyWork EmptyWork left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: bukan hide-other-onclick tapi hide-self-onclick

yoga1234
yoga1234 reviewed Nov 27, 2021
View reviewed changes
Comment thread 2-ui/2-events/01-introduction-browser-events/01-hide-other/task.md Outdated
yoga1234
yoga1234 reviewed Nov 27, 2021
View reviewed changes
Comment thread 2-ui/2-events/01-introduction-browser-events/03-which-handlers-run/solution.md Outdated
yoga1234
yoga1234 reviewed Nov 27, 2021
View reviewed changes
Comment thread 2-ui/2-events/01-introduction-browser-events/article.md Outdated
yoga1234
yoga1234 reviewed Nov 27, 2021
View reviewed changes

@yoga1234 yoga1234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ada beberapa typo

@EmptyWork

EmptyWork commented Nov 28, 2021

Copy link
Copy Markdown
Contributor Author

@yoga1234 lebih baik untuk handler itu di terjemahkan sebagai pengendali atau penangan?

@yoga1234

yoga1234 commented Nov 28, 2021

Copy link
Copy Markdown
Contributor

@yoga1234 lebih baik untuk handler itu di terjemahkan sebagai pengendali atau penangan?

Sepertinya penangan, karena belum ditentukan bakal pake apa jjuga sih..

@yoga1234

yoga1234 commented Nov 28, 2021

Copy link
Copy Markdown
Contributor

@EmptyWork kalo ada masukan boleh PR kesini bro - glossary

yoga1234
yoga1234 approved these changes Nov 28, 2021
View reviewed changes

@yoga1234 yoga1234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yoga1234
yoga1234 marked this pull request as ready for review November 29, 2021 05:48
@yoga1234
yoga1234 merged commit 0a7a0ad into javascript-tutorial:master Nov 29, 2021
@EmptyWork EmptyWork mentioned this pull request Nov 29, 2021
Merged
@EmptyWork EmptyWork mentioned this pull request Dec 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoga1234 yoga1234 yoga1234 approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EmptyWork @CLAassistant @yoga1234 @javascript-translate-bot