Visitar URL original
Forms: event and method submit by pierangelomiceli · Pull Request #228 · javascript-tutorial/it.javascript.info · GitHub
Skip to content

Forms: event and method submit - #228

Closed
pierangelomiceli wants to merge 10 commits into
javascript-tutorial:masterfrom
pierangelomiceli:015_forms_eve
Closed

Forms: event and method submit#228
pierangelomiceli wants to merge 10 commits into
javascript-tutorial:masterfrom
pierangelomiceli:015_forms_eve

Conversation

@pierangelomiceli

@pierangelomiceli pierangelomiceli commented Feb 20, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a team February 20, 2021 14:04
@javascript-translate-bot javascript-translate-bot mentioned this pull request Feb 20, 2021
Open
@longo-andrea

longo-andrea commented Feb 21, 2021

Copy link
Copy Markdown
Contributor

Gli articoli tradotti nelle PR #227 e #228 si sono accumulati in questa PR... gli articoli in "eccesso" vanno rimossi prima della revisione

@pierangelomiceli

pierangelomiceli commented Feb 21, 2021

Copy link
Copy Markdown
Contributor Author

Gli articoli tradotti nelle PR #227 e #228 si sono accumulati in questa PR... gli articoli in "eccesso" vanno rimossi prima della revisione

Dovrebbe essere tutto nella norma adesso. fammi sapere

@longo-andrea

longo-andrea commented Feb 22, 2021

Copy link
Copy Markdown
Contributor

Gli articoli tradotti nelle PR #227 e #228 si sono accumulati in questa PR... gli articoli in "eccesso" vanno rimossi prima della revisione

Dovrebbe essere tutto nella norma adesso. fammi sapere

A prima vista mi sembra siano i file giusti 👍 appena inizio a revisionarli ti faccio sapere se manca qualcosa

longo-andrea
longo-andrea approved these changes Feb 23, 2021
View reviewed changes
Comment thread 2-ui/4-forms-controls/4-forms-submit/article.md Outdated
Comment thread 2-ui/4-forms-controls/4-forms-submit/article.md Outdated
Comment thread 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md Outdated
Comment thread 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md Outdated
pierangelomiceli and others added 4 commits February 24, 2021 01:22
@pierangelomiceli @longo-andrea
Update 2-ui/4-forms-controls/4-forms-submit/article.md
a8cbea7 
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli @longo-andrea
Update 2-ui/4-forms-controls/4-forms-submit/article.md
b4920b1 
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli @longo-andrea
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
3386767 
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli @longo-andrea
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md
bc1fc9a 
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
Dorin-David
Dorin-David reviewed Feb 26, 2021
View reviewed changes
Comment thread 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
# Modal form

Create a function `showPrompt(html, callback)` that shows a form with the message `html`, an input field and buttons `OK/CANCEL`.
Creare una funzione `showPrompt(html, callback)` che mostra un form con un messaggio `html`, un campo di input ed i pulsanti `OK/CANCEL`.

@Dorin-David Dorin-David Feb 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Creare una funzione `showPrompt(html, callback)` che mostra un form con un messaggio `html`, un campo di input ed i pulsanti `OK/CANCEL`.
Create una funzione `showPrompt(html, callback)` che mostri un form con un messaggio `html`, un campo di input ed i pulsanti `OK/CANCEL`.

Suggerirei l'imperativo. Che ne pensi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@longo-andrea longo-andrea longo-andrea approved these changes
+1 more reviewer
@Dorin-David Dorin-David Dorin-David left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierangelomiceli @longo-andrea @Dorin-David @javascript-translate-bot