Visitar URL original
Comments by sbielenica · Pull Request #26 · javascript-tutorial/pl.javascript.info · GitHub
Skip to content

Comments - #26

Merged
jakubdrozdek merged 4 commits into
javascript-tutorial:masterfrom
sbielenica:translate-comments
Oct 19, 2019
Merged

Comments#26
jakubdrozdek merged 4 commits into
javascript-tutorial:masterfrom
sbielenica:translate-comments

Conversation

@sbielenica

@sbielenica sbielenica commented Oct 12, 2019

Copy link
Copy Markdown
Contributor

I had some doubts in regards to formatting of original file.

Example:

Describe the architecture
:

I decided to add subheaders in similar fragments.

@javascript-translate-bot
javascript-translate-bot requested a review from a team October 12, 2019 10:42
@iliakan iliakan mentioned this pull request Oct 12, 2019
Open
@CLAassistant

CLAassistant commented Oct 12, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
jakubdrozdek
jakubdrozdek reviewed Oct 13, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
@jakubdrozdek

jakubdrozdek commented Oct 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sbielenica Wydaje mi się, że to oryginalne formatowanie z : powinno zostać. Widać ten portal używa podrasowanej składni Markdowna (co zresztą widać np. po wstawianych linkach). Lepiej zostawić zgodnie z oryginałem.

@sbielenica @jakubdrozdek
Apply suggestions from translation review
3b3f8d8 
Co-Authored-By: Jakub Drozdek <30927218+jakubdrozdek@users.noreply.github.com>
jakubdrozdek
jakubdrozdek reviewed Oct 17, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
@jakubdrozdek

jakubdrozdek commented Oct 17, 2019

Copy link
Copy Markdown
Contributor

@sbielenica Zostało jeszcze parę rzeczy. No i sugeruję wrócić do poprzedniej składni, zachowując format nagłówków, wcięcia itd. Po coś zostały tam wrzucone.

sbielenica and others added 2 commits October 19, 2019 13:22
@sbielenica @jakubdrozdek
Apply suggestions from translation review
6663170 
Co-Authored-By: Jakub Drozdek <30927218+jakubdrozdek@users.noreply.github.com>
@sbielenica
Revert to default formatting in 'Comments' page
31034a3
@jakubdrozdek
jakubdrozdek merged commit e63610e into javascript-tutorial:master Oct 19, 2019
@javascript-translate-bot

javascript-translate-bot commented Oct 19, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubdrozdek jakubdrozdek jakubdrozdek approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbielenica @CLAassistant @jakubdrozdek @javascript-translate-bot