Visitar URL original
Dynamic imports by danilolmc · Pull Request #419 · javascript-tutorial/pt.javascript.info · GitHub
Skip to content

Dynamic imports - #419

Merged
nazarepiedady merged 4 commits into
javascript-tutorial:masterfrom
danilolmc:update-dynamic-imports
Apr 8, 2024
Merged

Dynamic imports#419
nazarepiedady merged 4 commits into
javascript-tutorial:masterfrom
danilolmc:update-dynamic-imports

Conversation

@danilolmc

@danilolmc danilolmc commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a team January 8, 2024 16:08
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 8, 2024
Open
renan-tiberio
renan-tiberio suggested changes Feb 21, 2024
View reviewed changes
Comment thread 1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread 1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread 1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread 1-js/13-modules/03-modules-dynamic-imports/say.view/index.html
@javascript-translate-bot

javascript-translate-bot commented Feb 21, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@danilolmc
danilolmc force-pushed the update-dynamic-imports branch from 342d4cd to 192eff9 Compare February 21, 2024 02:43
@danilolmc

danilolmc commented Feb 21, 2024

Copy link
Copy Markdown
Contributor Author

/done

@nazarepiedady

nazarepiedady commented Apr 2, 2024

Copy link
Copy Markdown
Member

@peruibeloko, @jonnathan-ls, could you review this pull request?

jonnathan-ls
jonnathan-ls approved these changes Apr 7, 2024
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I added a commit with some adjustments such as pending translations 780f934

@jonnathan-ls

jonnathan-ls commented Apr 7, 2024

Copy link
Copy Markdown
Contributor

... could you review this pull request?

I added my review with contribution @nazarepiedady

nazarepiedady
nazarepiedady approved these changes Apr 8, 2024
View reviewed changes

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good, so I will pass it forward.

@nazarepiedady
nazarepiedady merged commit 60013b3 into javascript-tutorial:master Apr 8, 2024
@javascript-translate-bot

javascript-translate-bot commented Apr 8, 2024

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nazarepiedady nazarepiedady nazarepiedady approved these changes
@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes
@luizclr luizclr Awaiting requested review from luizclr
@odsantos odsantos Awaiting requested review from odsantos
@renan-tiberio renan-tiberio Awaiting requested review from renan-tiberio

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danilolmc @javascript-translate-bot @nazarepiedady @jonnathan-ls @renan-tiberio