Visitar URL original
Error handling with promises by AntonBurchak · Pull Request #231 · javascript-tutorial/uk.javascript.info · GitHub
Skip to content

Error handling with promises - #231

Merged
tarasyyyk merged 7 commits into
javascript-tutorial:masterfrom
AntonBurchak:translate/promise-error-handling
Dec 13, 2021
Merged

Error handling with promises#231
tarasyyyk merged 7 commits into
javascript-tutorial:masterfrom
AntonBurchak:translate/promise-error-handling

Conversation

@AntonBurchak

@AntonBurchak AntonBurchak commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented Dec 10, 2021 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ AntonBurchak
❌ Anton_Burchak

Anton_Burchak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Dec 10, 2021
Open
@AntonBurchak AntonBurchak reopened this Dec 10, 2021
@AntonBurchak

AntonBurchak commented Dec 10, 2021

Copy link
Copy Markdown
Contributor Author

@tarasyyyk Could you please review it?)

tarasyyyk
tarasyyyk requested changes Dec 12, 2021
View reviewed changes
Comment thread 1-js/11-async/04-promise-error-handling/01-error-async/solution.md Outdated
Comment thread 1-js/11-async/04-promise-error-handling/01-error-async/task.md
Comment thread 1-js/11-async/04-promise-error-handling/article.md Outdated
Comment thread 1-js/11-async/04-promise-error-handling/article.md Outdated
Comment thread 1-js/11-async/04-promise-error-handling/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Dec 12, 2021

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@AntonBurchak

AntonBurchak commented Dec 13, 2021

Copy link
Copy Markdown
Contributor Author

/done

@AntonBurchak

AntonBurchak commented Dec 13, 2021

Copy link
Copy Markdown
Contributor Author

@tarasyyyk review it again, please

@tarasyyyk
tarasyyyk merged commit 99c7f4f into javascript-tutorial:master Dec 13, 2021
@javascript-translate-bot

javascript-translate-bot commented Dec 13, 2021

Copy link
Copy Markdown
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@tarasyyyk

tarasyyyk commented Dec 13, 2021

Copy link
Copy Markdown
Collaborator

@all-contributors add @AntonBurchak for translation.

@allcontributors allcontributors Bot mentioned this pull request Dec 13, 2021
Merged
@allcontributors

allcontributors Bot commented Dec 13, 2021

Copy link
Copy Markdown
Contributor

@tarasyyyk

I've put up a pull request to add @AntonBurchak! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyk tarasyyyk tarasyyyk approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AntonBurchak @CLAassistant @javascript-translate-bot @tarasyyyk