Visitar URL original
Shadow DOM slots, composition by kolumb · Pull Request #381 · javascript-tutorial/uk.javascript.info · GitHub
Skip to content

Shadow DOM slots, composition - #381

Merged
dolgachio merged 2 commits into
javascript-tutorial:masterfrom
kolumb:shadow-dom-slots
Oct 24, 2022
Merged

Shadow DOM slots, composition#381
dolgachio merged 2 commits into
javascript-tutorial:masterfrom
kolumb:shadow-dom-slots

Conversation

@kolumb

@kolumb kolumb commented Aug 14, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Aug 14, 2022
Open
@dolgachio dolgachio added the in progress Translation in progress label Oct 12, 2022
dolgachio
dolgachio requested changes Oct 21, 2022
View reviewed changes

@dolgachio dolgachio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую, за чудовий переклад! Вибачаюсь, що вам довелося так довго чекати :)
Подивіться, будь ласка, мої коментарі і напишіть мені, якщо з чимось не згодні.

Comment thread 8-web-components/5-slots-composition/article.md

<user-card>
<span *!*slot="username"*/!*>John Smith</span>
<span *!*slot="username"*/!*>Тарас Мельник</span>

@dolgachio dolgachio Oct 21, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@dolgachio dolgachio removed the in progress Translation in progress label Oct 21, 2022
@kolumb @dolgachio
Apply suggestions from code review
677cba0 
Co-authored-by: Stanislav <s.dolgachov@gmail.com>
@kolumb

kolumb commented Oct 21, 2022

Copy link
Copy Markdown
Contributor Author

/done

@dolgachio

dolgachio commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

@all-contributors add @kolumb for translation

@allcontributors

allcontributors Bot commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

@stas-dolgachov

@kolumb already contributed before to translation

@dolgachio
dolgachio merged commit ea0420f into javascript-tutorial:master Oct 24, 2022
@javascript-translate-bot

javascript-translate-bot commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@kolumb
kolumb deleted the shadow-dom-slots branch October 24, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolgachio dolgachio dolgachio approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolumb @javascript-translate-bot @dolgachio