Visitar URL original
Shadow DOM styling by SamGreenberg · Pull Request #418 · javascript-tutorial/uk.javascript.info · GitHub
Skip to content

Shadow DOM styling - #418

Merged
dolgachio merged 2 commits into
javascript-tutorial:masterfrom
SamGreenberg:shadow-dom-styling
Dec 8, 2022
Merged

Shadow DOM styling#418
dolgachio merged 2 commits into
javascript-tutorial:masterfrom
SamGreenberg:shadow-dom-styling

Conversation

@SamGreenberg

@SamGreenberg SamGreenberg commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented Nov 23, 2022 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Nov 23, 2022
Open
dolgachio
dolgachio requested changes Dec 7, 2022
View reviewed changes

@dolgachio dolgachio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую, за чудовий переклад! Подивіться, будь ласка, мої коментарі :)

Comment thread 8-web-components/6-shadow-dom-style/article.md Outdated
Comment thread 8-web-components/6-shadow-dom-style/article.md Outdated
Comment thread 8-web-components/6-shadow-dom-style/article.md Outdated
Comment thread 8-web-components/6-shadow-dom-style/article.md Outdated
Comment thread 8-web-components/6-shadow-dom-style/article.md Outdated
Comment thread 8-web-components/6-shadow-dom-style/article.md Outdated
Comment thread 8-web-components/6-shadow-dom-style/article.md Outdated
Comment thread 8-web-components/6-shadow-dom-style/article.md Outdated
Comment thread 8-web-components/6-shadow-dom-style/article.md Outdated
Comment thread 8-web-components/6-shadow-dom-style/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@SamGreenberg @dolgachio
code review fixes
cfd3f68 
Co-authored-by: Stanislav <s.dolgachov@gmail.com>
@SamGreenberg

SamGreenberg commented Dec 8, 2022

Copy link
Copy Markdown
Contributor Author

/done

@dolgachio

dolgachio commented Dec 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@all-contributors add @SamGreenberg for translation

1 similar comment
@dolgachio

dolgachio commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

@all-contributors add @SamGreenberg for translation

@allcontributors allcontributors Bot mentioned this pull request Dec 8, 2022
Merged
@allcontributors

allcontributors Bot commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

@stas-dolgachov

I've put up a pull request to add @SamGreenberg! 🎉

dolgachio
dolgachio approved these changes Dec 8, 2022
View reviewed changes

@dolgachio dolgachio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ще раз дякую за ваш внесок!

@dolgachio
dolgachio merged commit 5a9e098 into javascript-tutorial:master Dec 8, 2022
@javascript-translate-bot

javascript-translate-bot commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolgachio dolgachio dolgachio approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SamGreenberg @CLAassistant @javascript-translate-bot @dolgachio