Visitar URL original
Switch by lobanov-oleh · Pull Request #42 · javascript-tutorial/uk.javascript.info · GitHub
Skip to content

Switch - #42

Merged
tarasyyyk merged 3 commits into
javascript-tutorial:masterfrom
lobanov-oleh:1_02_13
Aug 14, 2019
Merged

Switch#42
tarasyyyk merged 3 commits into
javascript-tutorial:masterfrom
lobanov-oleh:1_02_13

Conversation

@lobanov-oleh

@lobanov-oleh lobanov-oleh commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a team August 14, 2019 13:45
@CLAassistant

CLAassistant commented Aug 14, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

tarasyyyk
tarasyyyk requested changes Aug 14, 2019
View reviewed changes

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation! Please, fix small issue and I'll merge thit PR to master.

Comment thread 1-js/02-first-steps/13-switch/1-rewrite-switch-if-else/solution.md Outdated
Comment thread 1-js/02-first-steps/13-switch/1-rewrite-switch-if-else/task.md Outdated
Comment thread 1-js/02-first-steps/13-switch/2-rewrite-if-switch/solution.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@tarasyyyk
tarasyyyk merged commit 186b3c5 into javascript-tutorial:master Aug 14, 2019
@iliakan iliakan mentioned this pull request Aug 14, 2019
Open
@javascript-tutorial javascript-tutorial deleted a comment from allcontributors Bot Mar 6, 2020
@javascript-tutorial javascript-tutorial deleted a comment from allcontributors Bot Mar 6, 2020
@javascript-tutorial javascript-tutorial deleted a comment from allcontributors Bot Mar 6, 2020
@tarasyyyk

tarasyyyk commented Mar 6, 2020

Copy link
Copy Markdown
Collaborator

Thanks for contribution!
@all-contributors add @lobanov-oleh for translation.

@allcontributors allcontributors Bot mentioned this pull request Mar 6, 2020
Merged
@allcontributors

allcontributors Bot commented Mar 6, 2020

Copy link
Copy Markdown
Contributor

@tarasyyyk

I've put up a pull request to add @lobanov-oleh! 🎉

@tarasyyyk tarasyyyk removed the needs +1 label Mar 6, 2020
@tarasyyyk tarasyyyk changed the title 1_02_13 switch Switch Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyk tarasyyyk tarasyyyk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lobanov-oleh @CLAassistant @javascript-translate-bot @tarasyyyk