Visitar URL original
Coding style by alexgalkin · Pull Request #59 · javascript-tutorial/uk.javascript.info · GitHub
Skip to content

Coding style - #59

Merged
tarasyyyk merged 27 commits into
javascript-tutorial:masterfrom
alexgalkin:master
Feb 27, 2020
Merged

Coding style#59
tarasyyyk merged 27 commits into
javascript-tutorial:masterfrom
alexgalkin:master

Conversation

@alexgalkin

@alexgalkin alexgalkin commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Another attempt to prepare PR for translation (as mentioned previously SVG will be changed using YAML file later). Please review and comment.

@javascript-translate-bot
javascript-translate-bot requested a review from a team February 26, 2020 01:42
tarasyyyk
tarasyyyk requested changes Feb 26, 2020
View reviewed changes

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good translation!
Please, made small corrections and I'll merge this PR.

Comment thread 1-js/03-code-quality/02-coding-style/article.md Outdated
# Стандарт оформлення коду

Our code must be as clean and easy to read as possible.
Наш код повинен бути настільки чистим та зрозумілим наскільки це можливо.

@tarasyyyk tarasyyyk Feb 26, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

«настільки зрозумілим та читабельним, наскільки це можливо»

Comment thread 1-js/03-code-quality/02-coding-style/article.md
Comment thread 1-js/03-code-quality/02-coding-style/article.md Outdated
-->

Now let's discuss the rules and reasons for them in detail.
Давайте розберемо ці правила і причини їх з'явлення більш детально.

@tarasyyyk tarasyyyk Feb 26, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

«Давайте детальніше розглянемо ці правила і причини їх появи»

Comment thread 1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread 1-js/03-code-quality/02-coding-style/article.md
Comment thread 1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread 1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread 1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread 1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread 1-js/03-code-quality/02-coding-style/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

alexgalkin and others added 10 commits February 27, 2020 00:14
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/02-coding-style/article.md
593e2e1 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/02-coding-style/article.md
b719b94 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/02-coding-style/article.md
3f363f2 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin
Fix minor typos and mistakes
f6ea17d
@alexgalkin
Merge branch 'master' of github.com:alexgalkin/uk.javascript.info
466d476
@alexgalkin
Fix minor typos and mistakes
4f4e0cb
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/02-coding-style/article.md
d8bd044 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/02-coding-style/article.md
aa0e0ce 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/02-coding-style/article.md
74d9c97 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin
Fix mistakes according to the review
11aaeb4
@alexgalkin
alexgalkin requested a review from tarasyyyk February 26, 2020 22:45
@alexgalkin

alexgalkin commented Feb 26, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team February 26, 2020 22:45
tarasyyyk
tarasyyyk requested changes Feb 27, 2020
View reviewed changes

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last small correction need to be fixed before merge.

Comment thread 1-js/03-code-quality/02-coding-style/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Feb 27, 2020

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@alexgalkin
alexgalkin requested a review from tarasyyyk February 27, 2020 18:37
tarasyyyk
tarasyyyk approved these changes Feb 27, 2020
View reviewed changes

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you for contribution!

@tarasyyyk
tarasyyyk merged commit c792b67 into javascript-tutorial:master Feb 27, 2020
@iliakan iliakan mentioned this pull request Feb 27, 2020
Open
@tarasyyyk tarasyyyk removed the needs +1 label Mar 6, 2020
@tarasyyyk tarasyyyk changed the title Translate Code Style section Coding style Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyk tarasyyyk tarasyyyk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexgalkin @javascript-translate-bot @tarasyyyk