Visitar URL original
Comments by alexgalkin · Pull Request #60 · javascript-tutorial/uk.javascript.info · GitHub
Skip to content

Comments - #60

Merged
tarasyyyk merged 14 commits into
javascript-tutorial:masterfrom
alexgalkin:translation/comments
Feb 29, 2020
Merged

Comments#60
tarasyyyk merged 14 commits into
javascript-tutorial:masterfrom
alexgalkin:translation/comments

Conversation

@alexgalkin

@alexgalkin alexgalkin commented Feb 28, 2020

Copy link
Copy Markdown
Contributor

Translation of the "Comments" section.

@javascript-translate-bot
javascript-translate-bot requested a review from a team February 28, 2020 21:12
tarasyyyk
tarasyyyk requested changes Feb 29, 2020
View reviewed changes

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small corrections

Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated

*!*
// check if i is a prime number
// перевірка чи є i простим числом

@tarasyyyk tarasyyyk Feb 29, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// перевірка чи є i простим числом
// перевірка чи є 'i' простим числом

Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
Comment thread 1-js/03-code-quality/03-comments/article.md
}
```
Наприклад:

@tarasyyyk tarasyyyk Feb 29, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space.
It's better to add this one to English version as PR and this will be merged into Ukrainian if approved.

@alexgalkin alexgalkin Feb 29, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created separate PR javascript-tutorial/en.javascript.info#1780 for this in English version

Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Feb 29, 2020

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@iliakan iliakan mentioned this pull request Feb 29, 2020
Open
alexgalkin and others added 8 commits February 29, 2020 22:48
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
8ef3e3a 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
49c4109 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
0f5d422 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
379d44a 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
6630148 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
bcdc3d1 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
68ca202 
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin
Small correction to variable i ref
e731e5a
@alexgalkin

alexgalkin commented Feb 29, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team February 29, 2020 21:00
@alexgalkin
alexgalkin requested review from tarasyyyk and removed request for a team February 29, 2020 21:00
@tarasyyyk
tarasyyyk merged commit aabd08b into javascript-tutorial:master Feb 29, 2020
@tarasyyyk tarasyyyk changed the title Translation of "Comments" section Comments Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyk tarasyyyk Awaiting requested review from tarasyyyk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexgalkin @javascript-translate-bot @tarasyyyk