Repository navigation
Conversation
The overview still showed dispatch() without an event object and said the default event objects would be removed in 3.0. Both have been deprecated since 2.0 and go away in 5.0. Show the replacement in every example and name the 5.0 removals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
CI fails in "Install PHP dependencies" before any check runs, independent of this change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Since 2.0, calling
Dispatcher::dispatch()without an event object, the default event objects (setEvent(),addEvent(),hasEvent(),getEvent(),removeEvent(),getEvents(),clearEvents(),countEvents()),Dispatcher::triggerEvent()andEvent::stop()are deprecated, and the deprecation notices say they will be removed in 5.0.docs/overview.mdstill usesdispatch('onAfterSomething')without an event in "Dispatching Events" and in the "Observable classes" example, and says the default event objects will be removed "in 3.0".This PR updates the docs only:
dispatch()).new Event(...)todispatch().The removal itself is a separate 5.x PR.
Testing Instructions
Documentation only; review the text.
Documentation Changes Required
This is the documentation change (
docs/overview.md).Related to #50 (also edits
docs/overview.md, in a different section).🤖 Generated with Claude Code